Repository navigation
Onboarding: found model first, profile grouped by who sees it, summary at the end - #117
Merged
Merged
Conversation
… in one selection. Co-authored-by: Cursor <cursoragent@cursor.com>
…hievement or event. Closes #111 Co-authored-by: Cursor <cursoragent@cursor.com>
… it, and ends on a summary of what was saved. The model step scans on open, hides embedding models, and moves ports and addresses under Advanced. The profile takes one name and keeps only the street private. A Done card counts jobs, schools, skills, and resumes, and opens a role on its Evidence tab. Links, skipped answers, skills, and the no-model path are fixed along the way. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the variants picked for #112, #113, and #114, plus the onboarding bug fixes from the review.
Model step (#112, variant 1). The local scan starts when the step opens. A found model is offered with "Use this model"; ports and a custom address sit under Advanced; the cloud card carries its own warning; "Skip, I'll add jobs myself" replaces the Yes/No question. Embedding and reranking models are left out of the scan results.
Profile step (#113, variant 3). One Name field. "About you · can be published" holds the photo, name, city, state, and links; "Only for you · never published" holds the street. City and State carry a note on when a published page shows them. Continue says it needs a name.
End of onboarding (#114, variant 1). A Done card counts jobs, schools, skills, and resumes kept, notes how many were set aside, and offers Go to Home, Add evidence to a role (opens the newest job on its Evidence tab), and See your map. Counts come from
onboardingDoneincore/. A session that kept no history still goes straight to Home.Fixes. Links can be entered on the profile step and are checked. Blank answers keep values read from the resume. Skills can be revised one per line before saving. Back on the model step returns to the profile. The no-model note on the resume step is accurate.
Tests: 320 pass. Type check: only the existing
GmailSettings.tsxerrors.Closes #112
Closes #113
Closes #114
Made with Cursor