Conversation
The CI runner's stable toolchain moved from 1.98.1 to 1.99.0 on 2026-10-01, and `cargo clippy --workspace --all-targets -D warnings` now fails on unchanged code: - `clippy::double_must_use` fires on the code `async-trait` 0.1.89 generates for every `#[async_trait]` trait (first hit: `fakecloud-core` `AwsService`). async-trait 0.1.92 stops emitting the redundant `#[must_use]` (dtolnay/async-trait#303); bumped in Cargo.lock. - `AtomicU64::fetch_update` is deprecated in 1.99 in favour of `try_update`, which is newer than the workspace `rust-version` (1.94), so the call keeps `fetch_update` under a scoped `allow(deprecated)` with a note to switch once the MSRV reaches 1.99. - `clippy::needless_borrows_for_generic_args` on closures passed by reference to `is_some_and` / `map` in S3 annotations and SES templates. Workspace clippy is clean on 1.99.0 and 1.98.1; core, s3 and ses build on 1.94.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub runner's stable toolchain moved from Rust 1.98.1 to 1.99.0 on 2026-10-01.
cargo clippy --workspace --all-targets -- -D warningsnow fails on unchanged code (first seen on #6, whose diff doesn't touch any of these files; upstreammainlast passed clippy on 1.98.1).Fix
clippy::double_must_usefires on the codeasync-trait0.1.89 generates for every#[async_trait]trait (first hit:AwsServiceinfakecloud-core). async-trait 0.1.92 stops emitting the redundant#[must_use](Resolve double_must_use clippy lint dtolnay/async-trait#303). Bumped inCargo.lockonly.AtomicU64::fetch_updateis deprecated in 1.99 in favour oftry_update.try_updateis newer than the workspacerust-version(1.94, which CI also builds), so the call keepsfetch_updateunder a scoped#[allow(deprecated)]with a note to switch once the MSRV reaches 1.99.clippy::needless_borrows_for_generic_argson closures passed by reference tois_some_and/mapin S3 annotations and SES templates.Verification
cargo clippy --workspace --all-targets -- -D warningsis clean on 1.99.0 (--keep-going, so no crate was hidden behind a failing dependency) and on 1.98.1.cargo check --all-targetson 1.94 for core, s3 and ses.