Repository navigation
fix: close the r7-nx12 numeric-key and RegExp statics holes - #473
Merged
Merged
Conversation
…elf-defending when RegExp statics may be read
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three findings in review/r7-nx12.md.
arguments, a top-level binding with a host-provided name (exports,module,require, ...), or avarthat an Annex B block function may overwrite. This also covers the direct-eval unfold and the spread untranspile.RegExp[q],/x/.constructor.$1, a key it cannot resolve) as observing the callback's searches, and keeps the block with the unproven note. README documents the matching --unsafe premise.Rows: crates/untwist/tests/review_r7_nx12_rows.rs (64 probes, both lanes vs node) and builtins_numeric_keys.rs.
Full sweep vs main c9ceaba: no verdict changes in either lane. Krunker gate byte-identical in both lanes. BASELINEs unchanged.