Repository navigation
fix: treat a method call on the base of an assembled object as a write - #472
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F1 in review/r7-c2.md. The dead-branch proof through an assembled object judged a method call on the base by the key's last value, so a call made while the key-by-key run was half done (
m.ggggg = m.fffff(); m.fffff = function () { return 1; }) could hide athiswrite and a live branch was removed.Now any call whose receiver is the base of a view with added keys counts as a write. Calls through the alias keep the old check.
Rows cfo-r7-h1a to h1h in obfuscator_sweep_rows.rs, both lanes vs node.
Checks against main bb5ecd8: full obfuscator.io sweep identical per case in both lanes (all 39 lanes #455 gained kept), Krunker outputs byte-identical in both lanes, obfuscator BASELINEs unchanged, local untwist-ci --web green (wasm under the cap).