Repository navigation
fix: keep Annex B block functions out of the string-array wraps - #471
Merged
Merged
Conversation
…t of the string-array wraps
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes D1 and D2 of review r7-ml8-d4.
A block function in sloppy code also writes its value to the outer var binding of the same name (Annex B). The block-rotator wrap moved such a leading function into a new function, so that copy was lost (node
function, untwistnumber, both lanes). The wrap now refuses a leading function declaration when a scope above the block binds the name, when the enclosing var scope is the top level, or when the name is an unresolved reference. The called rotator plan keeps such a function in its block, and the cookie wrap refuses such a declared rotator. checksum_plan moves only var aliases and the loop, so it was not affected. A leadingusing/await usingdeclaration is refused too.Rows for the eight r7 repros, a called-rotator repro and the two
usingshapes. Full obfuscator sweep identical per case to main in both lanes, the #461 cases (pw012-n3, rnd000-m2) byte-identical, Krunker byte-identical in both lanes.