Repository navigation
fix: make getter, descriptor and Proxy copies carry their source - #435
Merged
Merged
Conversation
…keep enumerability-preserving copies to what the source carries
Sorte1
force-pushed
the
fix/r51-bfx7b
branch
from
November 17, 2026 16:42
68a9da2 to
62fff7a
Compare
…es with the copy carry
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes L1 and L2 from review r3-a33rr6-bfy, following the lead ruling.
definePropertywithget: () => s[k]or the bound form) now makes the target carry its source. When the copy keeps the source's enumerability, the target carries only whatscarries. That covers noenumerable,enumerable: false, and esbuild's and rolldown's__copyPropsflag!(d = __getOwnPropDesc(from, key)) || d.enumerableover keys from__getOwnPropNames(from). Any other getter copy carries the read itself.defineProperty(t, k, getOwnPropertyDescriptor(s, k))carries whatscarries, while a descriptor held in a local carries the read.defineProperties(t, getOwnPropertyDescriptors(s))carries whatscarries, andObject.createwith a carrying source is refused.gettrap is exempt only when it reads its own target ((a, b) => a[b]) and that target carries nothing.The probes are added as rows
r7l1andr7l2, and both keep the bundle whole now.Lost splits: none in the bundle matrix or the rollup-boundaries and rollup-assume EXPECTs, so esbuild and rolldown interop of plain module exports still splits. One shape is now refused: esbuild's
__requireshim. Its Proxy trap reads the freerequire, so an esbuild bundle that holds the shim stays whole in the default lane (bm-computed-key-unproven);--unsafestill splits it. No matrix cell contains that shim.Gates:
--unsafe.