Skip to content

fix: make getter, descriptor and Proxy copies carry their source - #435

Merged
Sorte1 merged 3 commits into
mainfrom
fix/r51-bfx7b
Nov 17, 2026
Merged

Sorte1 merged 3 commits into
mainfrom
fix/r51-bfx7b

Conversation

@Sorte1

@Sorte1 Sorte1 commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Closes L1 and L2 from review r3-a33rr6-bfy, following the lead ruling.

  • A getter copy (defineProperty with get: () => s[k] or the bound form) now makes the target carry its source. When the copy keeps the source's enumerability, the target carries only what s carries. That covers no enumerable, enumerable: false, and esbuild's and rolldown's __copyProps flag !(d = __getOwnPropDesc(from, key)) || d.enumerable over keys from __getOwnPropNames(from). Any other getter copy carries the read itself.
  • The same rule now covers descriptor copies. defineProperty(t, k, getOwnPropertyDescriptor(s, k)) carries what s carries, while a descriptor held in a local carries the read. defineProperties(t, getOwnPropertyDescriptors(s)) carries what s carries, and Object.create with a carrying source is refused.
  • A Proxy get trap is exempt only when it reads its own target ((a, b) => a[b]) and that target carries nothing.

The probes are added as rows r7l1 and r7l2, and both keep the bundle whole now.

Lost splits: none in the bundle matrix or the rollup-boundaries and rollup-assume EXPECTs, so esbuild and rolldown interop of plain module exports still splits. One shape is now refused: esbuild's __require shim. Its Proxy trap reads the free require, so an esbuild bundle that holds the shim stays whole in the default lane (bm-computed-key-unproven); --unsafe still splits it. No matrix cell contains that shim.

Gates:

  • Bundle matrix: 0 failed, 0 unexpected-pass.
  • Obfuscator BASELINEs and both rollup EXPECTs unchanged.
  • Game and Krunker samples: output trees identical to main in default and --unsafe.
  • untwist-ci green.

@Sorte1
Sorte1 merged commit 8281eed into main Nov 17, 2026
9 checks passed
@Sorte1
Sorte1 deleted the fix/r51-bfx7b branch November 17, 2026 17:38

This branch was successfully deployed

1 active deployment
preview — 8c05de31 Deployed Nov 17, 2026 by Sorte1 via deploy #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant