Kit versions#2
Open
brendanclarke wants to merge 5 commits intoSonicPotions:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Julian,
I've moved my (rather extensive and hard-to-parse) custom firmware to a new branch and done a hard reset on my master.
I've made some very small changes to add versioning to kit-files so that people don't have to worry about filter 'off' being changed to LP2 when moving from .34 to .36. It also lets kits track any future changes in the same way as 'all' and 'performance' file types. Kit files are cross-compatible between .34 and .36, the version number doesn't load on earlier firmware. Patterns don't recognize file versions yet, it might be a good thing to add eventually.
If there are any features you would like me to move into the standard firmware from my 'custom' set, let me know and I'll do my best to re-create them so they can be easily merged one at a time.