Closed
Conversation
Dahie
commented
Feb 4, 2025
Collaborator
Author
There was a problem hiding this comment.
Is/Was this being used?
Collaborator
Author
There was a problem hiding this comment.
in that case I would add a quick github task for linting and rspec
I'm cool with standardrb |
spilth
approved these changes
Feb 4, 2025
spilth
approved these changes
Feb 11, 2025
Collaborator
Author
|
@spilth Thanks for the approval, I can merge it now. When can you release it on rubygems? |
|
@Dahie I can release it on RubyGems as soon as you merge it 👍🏻 |
|
Whoops, I didn't realize moving master to main would close this PR |
Merged
|
Reopened here: #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #1 here is a ruby update, to 3.2.4. The latest is 3.4.1 which doesn't change anything in terms of code.
In my gems I started using standardrb for linting, I can add this here as well in a later PR if you are interested.