Fix Edge native password reveal icon overlap#3434
Conversation
SummaryThis PR fixes a visual issue in Microsoft Edge where the browser's native password reveal icon ( The fix adds a small inline style that hides Edge's native controls using CSS-only targeting ( What reviewers should knowWhat changed: One Java file ( Start here: The entire change is in
Why it works: The fix targets only Edge-specific pseudo-elements using the Scope: The change applies globally to all HTML pages served through this cache, which is appropriate since the password reveal overlap is a global UI concern on the login page.
|
![sonar-review-alpha[bot]](https://avatars.githubusercontent.com/in/3025063?s=60&v=4){kind=small}
There was a problem hiding this comment.
The fix is the right approach for this browser-specific issue, and the CSS selectors are correct for both modern Chromium-based Edge and Edge Legacy. However, the implementation has a test coverage gap that means the new behavior is never actually exercised by the test suite.
…ixture to include </head> and asserting the injected ::-ms-reveal and ::-ms-clear styles are present.
Code Review ✅ ApprovedHides Microsoft Edge's native password reveal and clear pseudo-elements by injecting CSS into the HTML shell, preventing icon overlap. Includes updated test coverage to verify the style injection. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
2 participants
Description
Microsoft Edge displays its native password reveal icon alongside SonarQube's custom password visibility toggle on the login page while typing in the password field.
The native icon disappears after focus changes, but duplicate controls are visible during initial interaction.
Root Cause
Edge injects a native reveal control for password inputs.
Fix
Hide Edge native reveal and clear pseudo-elements using a small inline style injected into the shared HTML shell.
Testing
The CSS rule was manually validated in Microsoft Edge using browser DevTools, confirming that hiding the native
::-ms-revealand::-ms-clearpseudo-elements removes the duplicate password reveal icon while preserving SonarQube's custom visibility toggle.Before Image:
After Image:
