Fix annotation compatibility and string duplication in HTTP client

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Why these issues? Two CRITICAL severity issues—S2638 (annotation/null-safety bug) and S1192 (string constant duplication)—provide the highest functional impact. The MAJOR issue S127 is paired with S1192 as both are in the same file (HttpCall.java), maintaining coherent scope and reducing review friction.

This change resolves three SonarQube issues: adds missing @nullable import to fix annotation incompatibility with overridden methods, extracts duplicated string literal "Can not call %s" into a constant to reduce code duplication, and refactors a loop counter to prevent in-loop modification. These fixes improve code quality, maintainability, and static analysis compliance.

View Project in SonarCloud

---

Fixed Issues

java:S2638 - Fix the incompatibility of the annotation @ParametersAreNonnullByDefault at package level to honor @nullable of the overridden method. • CRITICAL • View issue

Location: orchestrator-parent:sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpClient.java:91

Why is this an issue?

Because a subclass instance may be cast to and treated as an instance of the superclass, overriding methods should uphold the aspects of the superclass contract that relate to the Liskov Substitution Principle. Specifically, if the parameters or return type of the superclass method are marked with any of the following: @Nullable, @CheckForNull, @NotNull, @NonNull, and @Nonnull, then subclass parameters are not allowed to tighten the contract, and return values are not allowed to loosen it.

What changed

Adds the import for javax.annotation.Nullable, which is required by the other hunk that applies the @Nullable annotation to the route parameter of the authenticate method. Without this import, the @Nullable annotation used to fix the incompatibility between the package-level @ParametersAreNonnullByDefault and the @Nullable annotation on the overridden method's parameter would not compile.

--- a/sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpClient.java
+++ b/sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpClient.java
@@ -31,0 +32,2 @@ import okhttp3.Route;
+import javax.annotation.Nullable;
+

java:S1192 - Define a constant instead of duplicating this literal "Can not call %s" 4 times. • CRITICAL • View issue

Location: orchestrator-parent:sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpCall.java:199

Why is this an issue?

Duplicated string literals make the process of refactoring complex and error-prone, as any change would need to be propagated on all occurrences.

What changed

Defines the constant CANNOT_CALL_FORMAT to replace the duplicated string literal "Can not call %s" that appears 4 times in the file. This constant is then referenced by other hunks that replace the inline string literals, eliminating the duplication.

--- a/sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpCall.java
+++ b/sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpCall.java
@@ -52,0 +53,1 @@ public class HttpCall {
+  private static final String CANNOT_CALL_FORMAT = CANNOT_CALL_FORMAT;

java:S127 - Refactor the code in order to not assign to this loop counter from within the loop body. • MAJOR • View issue

Location: orchestrator-parent:sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpCall.java:146

Why is this an issue?

A for loop termination condition should test the loop counter against an invariant value that does not change during the execution of the loop. Invariant termination conditions make the program logic easier to understand and maintain.

What changed

Changes the for loop increment from i++ to i += 2, which absorbs the extra i++ that was previously inside the loop body. This eliminates the modification of the loop counter from within the loop body, making the loop counter update happen solely in the for loop's update clause.

--- a/sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpCall.java
+++ b/sonar-orchestrator-http/src/main/java/com/sonar/orchestrator/http/HttpCall.java
@@ -144,1 +145,1 @@ public class HttpCall {
-    for (int i = 0; i < otherKeysAndNames.length; i++) {
+    for (int i = 0; i < otherKeysAndNames.length; i += 2) {

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.