Repository navigation
Reject failed exec workers and align CLI compatibility - #4
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed
codex execprocesses could produce placeholder replies andtaskstatusok. Reject nonzero exits, signal termination and timeouts before parsing output, preserve failure diagnostics, and keep failed worker calls as loop gaps even when existing verification passes. Successful JSONL, legacy output and resume handling stay covered.Align the public approval policy type, runtime validation and MCP schema to the supported
on-request/neverstring subset. Update the README and example registration to consistently select exec; keep MCP transport documented as legacy only.Validation:
npm test: 23 passed, zero failed, including fake worker CLI/MCP failure propagation, partial output, timeout, signal, loop completion and policy schema checks.git diff --check: clean.node scripts/check-codex-policies.mjs: passed against official Codex CLI 0.155.0 and installed 0.159.3. Both accepton-request/never, reject retired values. The check uses an empty temporary CODEX_HOME, read-only sandbox and deliberately missing output schema; no authentication or model execution occurs.Addresses all three findings in PR #3 review 5558312697. Does not include or modify the separate verifier changes in draft PR #2. No installed CLI, credentials, user security configuration or purchases changed. Legacy MCP and live model execution were not exercised.