Skip to content

Improve image discovery performance #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoClosee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve image discovery performance #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,23 +133,17 @@ def load_csv_metadata(csv_path):


def discover_images(folder_path):
"""Return a sorted list of image file paths in *folder_path*."""
"""Return a generator of image file paths in *folder_path*."""
folder = Path(folder_path)
if not folder.is_dir():
logger.error("Images folder not found: %s", folder)
sys.exit(1)

images = sorted(
str(p) for p in folder.iterdir()
if p.is_file() and p.suffix.lower() in SUPPORTED_EXTENSIONS
)

if not images:
logger.error("No images found in %s", folder)
sys.exit(1)
for p in folder.iterdir():
if p.is_file() and p.suffix.lower() in SUPPORTED_EXTENSIONS:
yield str(p)

logger.info("Found %d image(s) in %s", len(images), folder)
return images
logger.info("Found images in %s", folder)


def create_driver(headless=False):
Expand Down