Fix strange scroll-back at the channel bottom - #2265
Closed
koteitan wants to merge 1 commit into
Closed
Conversation
- Enable virtua shift mode only for events inserted at the list start - Re-scroll bottom-pinned views when the rendered list height changes - Align the window to the document bottom after virtualizer scrolling
Contributor
Author
|
The issue is no longer reproducible now that the thread has advanced. |
Contributor
Author
|
I found the issue was not resolved completely by the fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mechanism
shiftmode.shiftenabled, virtua interprets the array-length increase as all new items having been prepended. It therefore:nwas then used as the estimated height of the message at indexn + 1.Changes
shiftmode only when an older event is inserted at the start of the message list. Mid-list and end insertions now use the normal anchoring mode.test
npm run check→ passed with 0 errors and 0 warningsnpm test -- --run→ 17 test files and 161 tests passednpm run build→ passed