[WIP] Prototype a Dispatch2/GlobalDispatch2 trait to dispatch delegate macros to oblivion#2008
Draft
ids1024 wants to merge 50 commits intoSmithay:masterfrom
Draft
[WIP] Prototype a Dispatch2/GlobalDispatch2 trait to dispatch delegate macros to oblivion#2008ids1024 wants to merge 50 commits intoSmithay:masterfrom
Dispatch2/GlobalDispatch2 trait to dispatch delegate macros to oblivion#2008ids1024 wants to merge 50 commits intoSmithay:masterfrom
Conversation
docs examples remove `delegate_seat` remove `delegate_shm`
5 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2008 +/- ##
==========================================
- Coverage 18.73% 15.99% -2.74%
==========================================
Files 182 183 +1
Lines 28934 29208 +274
==========================================
- Hits 5421 4673 -748
- Misses 23513 24535 +1022
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See Smithay/client-toolkit#519 for a bit more context.
At present, this replaces
delegate_compositor!with a single genericdelegate_dispatch2!macro. It should be possible to update all the dispatch implementations this way.If there are no issues with this, since
smithayis less strict about API breaks thanwayland-rs, we could merge this insmithay(compositors mostly should just need to adddelegate_dispatch2!and remove the other macro calls). Then the next wayland-rs version (Smithay/wayland-rs#900) can incorporate the updated version of the trait. At which point the macro is no longer necessary, and more type bounds can be remove as implied.Checklist