Repository navigation
ci: sidecar paths 改为 app/** - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
只改了
.github/workflows/sidecar.yml的paths。问题：原来的 paths 只写了
app/sidecar.py、app/tools/sandbox*.py、app/tools/_winjob.py、app/server/**。从app.sidecar静态分析 import，能走到 37 个模块，其中 28 个不在 paths 里，包括app/core/*、app/nodes/*、app/react_agent.py、app/tools/charts.py。结果是几乎所有后端改动都触发不了 sidecar，Windows 打包坏了也没人知道。判据：看最终产物里会包含哪些文件，而不是看依赖闭包。
packaging/build_sidecar.py用了--collect-submodules app，整个包都会打进去，所以 paths 直接写app/**。依赖闭包碰到一句importlib.import_module就会漏，按目录写不会。代价：以后每改一次后端，就多跑一次 Windows 打包。这个代价必须付：少跑一次只省一点 CI 时间，而打包坏了没人发现，代价大得多。触发方式以后可以再优化，但 paths 必须先改成
app/**。这个 PR 改的是 workflow 文件本身，所以 sidecar 会被触发，顺带实测一次。只是 CI 配置修正，不算一步，所以没有新开 DEVLOG 条目。