API BREAK: reduce allocations during symbol resolution - #340
Merged
Conversation
Smattr
force-pushed
the
smattr/github-335
branch
2 times, most recently
from
August 16, 2026 20:45
dffa7d4 to
84c1d32
Compare
Profiling reveals runtime of `murphi2xml` on the CMurphi example sci.m is dominated by symbol resolution, bottoming out on time spent cloning AST nodes. This change alleviates some of this copying, though more could be done. This change is a 17% speed up on this `murphi2xml` workload, 15.72s → 12.30s. Github: #335 “'std::move' optimisations”
Smattr
force-pushed
the
smattr/github-335
branch
from
August 16, 2026 20:47
84c1d32 to
75e56bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling reveals runtime of
murphi2xmlon the CMurphi example sci.m is dominated by symbol resolution, bottoming out on time spent cloning AST nodes. This change alleviates some of this copying, though more could be done. This change is a 17% speed up on thismurphi2xmlworkload, 15.72s → 12.30s.Github: #335 “'std::move' optimisations”