feat: set requestId if not provided, log requestId on low level excep…#118
Merged
sl-pkryshtop merged 1 commit intomasterfrom Aug 7, 2025
Merged
Conversation
sl-pkryshtop
requested review from
AlexArcher and
bloy-smartling
as code owners
sl-pkryshtop
requested review from
dimitrystd,
sl-mmuradov and
vfisyuk-smartling
sl-mmuradov
reviewed
Aug 4, 2025
...api-commons/src/main/java/com/smartling/api/v2/client/exception/RestApiRuntimeException.java
Show resolved
Hide resolved
sl-mmuradov
reviewed
Aug 4, 2025
...api-commons/src/main/java/com/smartling/api/v2/client/exception/RestApiRuntimeException.java
Show resolved
Hide resolved
dimitrystd
approved these changes
Aug 4, 2025
Contributor
dimitrystd
left a comment
dimitrystd
left a comment
There was a problem hiding this comment.
The idea of the fake response doesn't look good. Perhaps because of the name. But I couldn't make a better proposal.
Contributor
Author
I copied it from WebApplicationException (parent of our RestApiException), just include additional header. |
dimitrystd
reviewed
Aug 4, 2025
...api-commons/src/main/java/com/smartling/api/v2/client/exception/RestApiRuntimeException.java
Outdated
Show resolved
Hide resolved
smartling-api-commons/src/main/java/com/smartling/api/v2/client/DefaultRequestIdFilter.java
Outdated
Show resolved
Hide resolved
sl-mmuradov
approved these changes
Aug 4, 2025
sl-pkryshtop
force-pushed
the
CON-1787-improve-request-id-logging
branch
from
c70ae37 to
9e449b1
Compare
dimitrystd
approved these changes
Aug 4, 2025
vfisyuk-smartling
approved these changes
Aug 5, 2025
AlexArcher
approved these changes
Aug 5, 2025
sl-pkryshtop
force-pushed
the
CON-1787-improve-request-id-logging
branch
from
9e449b1 to
f3d31ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.