Skip to content

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Dec 16, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Support the fanSpeedPercent capability for thermostats based on the presence of the MULTI_SPEED feature.

Summary of Completed Tests

Tested with thermostat-fan device and updated UTs

@github-actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Channel deleted.

@hcarter-775
Copy link
Contributor

I'd add a test, or update a previously existing test

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Test Results

   71 files    480 suites   0s ⏱️
2 483 tests 2 483 ✅ 0 💤 0 ❌
4 264 runs  4 264 ✅ 0 💤 0 ❌

Results for commit 3a14aab.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

File Coverage
All files 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/utils.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/embedded_cluster_utils.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/device_configuration.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/legacy_device_configuration.lua 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/attribute_handlers.lua 81%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/capability_handlers.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 98%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3a14aab

@nickolas-deboom
Copy link
Contributor Author

I'd add a test, or update a previously existing test

I added a test in the latest commit, lemme know if that seems sufficient.

@nickolas-deboom nickolas-deboom force-pushed the matter-thermostat-fan-speed-percent branch from 2645671 to fa07bdd Compare January 6, 2026 19:42
@nickolas-deboom nickolas-deboom force-pushed the matter-thermostat-fan-speed-percent branch from fa07bdd to 3a14aab Compare January 6, 2026 21:16
@nickolas-deboom nickolas-deboom merged commit 1defafc into main Jan 6, 2026
12 checks passed
@nickolas-deboom nickolas-deboom deleted the matter-thermostat-fan-speed-percent branch January 6, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants