Skip to content

CHAD-17040: Zwave thermostat lazy load subdrivers #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aleclorimer merged 1 commit into from
Dec 10, 2025
Merged

CHAD-17040: Zwave thermostat lazy load subdrivers #2582

aleclorimer merged 1 commit into from
Dec 10, 2025

Conversation

@aleclorimer
Copy link
Contributor

@aleclorimer aleclorimer commented Nov 25, 2025

Lazy loading of sub-drivers for zwave thermostat. Required some manual intervention to fix some subdrivers. Passing all unit tests now.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025 •
edited
Loading

Channel deleted.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025 •
edited
Loading

Test Results

   71 files    477 suites   0s ⏱️
2 471 tests 2 471 ✅ 0 💤 0 ❌
4 236 runs  4 236 ✅ 0 💤 0 ❌

Results for commit eb5724a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025 •
edited
Loading

File Coverage
All files 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/ct100-thermostat/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/stelpro-ki-thermostat/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/thermostat-heating-battery/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/popp-radiator-thermostat/init.lua 84% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua 43% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/aeotec-radiator-thermostat/init.lua 77% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/fibaro-heat-controller/init.lua 76% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against eb5724a

cjswedes
cjswedes approved these changes Nov 25, 2025
View reviewed changes
drivers/SmartThings/zwave-thermostat/src/aeotec-radiator-thermostat/can_handle.lua Outdated
end
end

return can_handle_aeotec_radiator_thermostat No newline at end of file
Copy link
Contributor

@cjswedes cjswedes Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/fingerprints.lua Outdated
{ manufacturerId = 0x0002, productType = 0x0005, productId = 0x0004 } -- Danfoss LC13 Thermostat
}

return DANFOSS_LC13_THERMOSTAT_FPS No newline at end of file
Copy link
Contributor

@cjswedes cjswedes Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/init.lua
Copy link
Contributor

@cjswedes cjswedes Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove this, as apiv6 was from awhile ago and there probably arent any more hubs with this version. Can you write a ticket?

@greens
Copy link
Contributor

greens commented Nov 25, 2025 

Checking drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua 3 warnings

    drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua:7:1: (W611) line contains only whitespace
    drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua:9:22: (W113) accessing undefined variable cc
    drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua:10:19: (W113) accessing undefined variable WakeUp

@aleclorimer aleclorimer force-pushed the zwave-thermostat-lazy-load-subdrivers branch from 88fa1fc to eb5724a Compare December 10, 2025 19:49
@aleclorimer aleclorimer changed the title Zwave thermostat lazy load subdrivers CHAD-17040: Zwave thermostat lazy load subdrivers Dec 10, 2025
@aleclorimer aleclorimer merged commit 2c7d3f5 into main Dec 10, 2025
11 checks passed
@aleclorimer aleclorimer deleted the zwave-thermostat-lazy-load-subdrivers branch December 10, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes cjswedes approved these changes

@greens greens Awaiting requested review from greens

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aleclorimer @greens @cjswedes