Repository navigation
fix(tests): make the full suite portable across hosts - #428
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows runs fail on shell-script fixtures, Wine's
c:filenames, hardcoded/separators, and CRLF fixtures converted twice. Run executable fixtures through Node, normalize the stock file before building LF and CRLF samples, and compare temporary paths with host path helpers. Child-process arguments, exit codes, cleanup, and byte-for-byte restoration are still checked.Wine drive-map tests now mock the filesystem entries that Windows cannot create. Bottle discovery still uses real directories. These tests also exposed a hardcoded
/infindBottleForPath; it now uses the host path separator.Verified on Windows: