Repository navigation
feat(performance): add Eskay's config and stop collapsing RenderModes - #426
Merged
Merged
Conversation
Add Eskay's config from OptimizationLock as a seventh preset under a new "light" tier (Sqooky's default minus the far-clip and fade-distance culling, so no pop-in). The 3.4 pin moves to e2e9925c, where upstream only reformatted the bundled files and added Eskay's; existing bodies are unchanged. The generator now accepts a null sha256 for older releases that predate a preset's file. Bundle avatars for Eskay and kaizuchanerus. Exclude MaterialSystem2/RenderModes. It is a list of seven `game` entries, so configs written before ShadowSilhouette existed (boot, OptiLock) diffed to `game "FrontDepth"`, and the patcher rewrote every render mode to FrontDepth. Cached track-latest bodies from older builds are filtered by today's section exclusions so the fix reaches them without a refetch.
Add an offline test that no bundled release edits an excluded section, since perf:presets --check is not in CI. Warn when --refresh records a null sha256 so a missing pathByRef is not mistaken for a file that did not exist yet. Fix the stale preset count in the old_update_rate rationale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eskay's config
Sqooky added
Eskay's config/to OptimizationLock on 2026-10-05 ("minor fork of Sqooky's with tweaks to suit her preferences"). It is Sqooky's default without the far-clip and fade-distance culling (r_farz,r_mapextents,sc_fade_distance_scale_override), so buildings and players don't pop in, plusprops_break_max_pieces_perframe 1and a 2.2 aspect-ratio opt-in.eskayunder a new Light tier (card titles are tier labels, so sharing Balanced would show two identical cards). Sorts right after Sqooky's Balanced, which stays first.2b994f62toe2e9925c. The commits in between only reformatted the bundled files (zero key changes through the generator) and added Eskay's file; upstream still states 3.4. 3.4 has not shipped in a release yet.nullsha256 for older releases where its file did not exist yet. Only a trailing run of older releases may be null; a null at the newest release fails loudly (file moved or deleted).RenderModes fix
MaterialSystem2/RenderModesin stock gameinfo.gi is a list of sevengameentries; City Never Sleeps addedShadowSilhouette. The parser keeps the last duplicate, so configs written before that (boot, OptiLock 4.6/5.0/5.1) diffed togame "FrontDepth", andapplyOpedits every occurrence, collapsing all seven render modes into FrontDepth.Fix: exclude the section in the manifest, and have
latestAsPresetre-apply today's section exclusions to cached bodies, since a cached track-latest entry is reused while upstream and baseline commits are unchanged. Already-affected files are restored on the next reapply or preset switch (removal works from the markers). In-game effect of the collapsed list was never tested.Testing
pnpm typecheck,pnpm lint,pnpm ui:check,pnpm i18n:check,pnpm i18n:manifest --check,pnpm perf:presets --check