Repository navigation
fix(locker): cursor preview transparency and General tab order - #421
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Locker fixes.
Cursor previews. The stock cursors (and some packs) are 32-bit BI_RGB BMPs with alpha in the reserved fourth byte. SDL reads it, Chromium treats it as padding, so transparent pixels (stored white) rendered opaque on the Default card.
getCursorPreviewnow re-headers those as BITMAPV5 with an explicit alpha mask (bmpWithExplicitAlphaincursorFiles.ts). All-zero alpha and files that already carry masks pass through untouched, matching how SDL loads them. Verified in Electron's decoder: all four stock cursors go from 0 transparent pixels to the expected cutouts. Main-process change, so dev needs a full restart.General tab order. The rail lists populated tabs first, then the empty ones, keeping the canonical order within each group. User categories keep their own order. The sliding highlight re-measures when the order shifts under the active tab.
Checks: cursor tests pass, eslint,
ui:check,tsc -b.