Skip to content

replacing MAVLink with ROS2 + PX4 #5

Open
aborjigin wants to merge 3 commits into
mainfrom
amber
Open

replacing MAVLink with ROS2 + PX4 #5
aborjigin wants to merge 3 commits into
mainfrom
amber

Conversation

@aborjigin
Copy link
Copy Markdown
Contributor

#4

Copilot AI review requested due to automatic review settings May 8, 2026 08:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces MAVLink-based telemetry/signaling with ROS 2 messaging to integrate with a ROS2 + PX4 pipeline (per Issue #4), publishing detections as ROS messages and receiving control signals via a ROS topic.

Changes:

  • Removed MAVLink UDP telemetry + STATUSTEXT signal handling from telemetry.py.
  • Added ROS 2 node lifecycle management (init/shutdown), a /vision/signal subscriber, and a /vision/detections publisher.
  • Wired ROS 2 init/shutdown into the main program lifecycle in main.py.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
telemetry.py Replaces MAVLink transport with ROS 2 pub/sub for detections and signals; adds ROS node lifecycle helpers.
main.py Initializes and shuts down the ROS 2 telemetry layer during program startup/exit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread telemetry.py
Comment thread telemetry.py
Comment thread telemetry.py Outdated
Copy link
Copy Markdown

@ehjucsc ehjucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants