Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces MAVLink-based telemetry/signaling with ROS 2 messaging to integrate with a ROS2 + PX4 pipeline (per Issue #4), publishing detections as ROS messages and receiving control signals via a ROS topic.
Changes:
- Removed MAVLink UDP telemetry + STATUSTEXT signal handling from
telemetry.py. - Added ROS 2 node lifecycle management (init/shutdown), a
/vision/signalsubscriber, and a/vision/detectionspublisher. - Wired ROS 2 init/shutdown into the main program lifecycle in
main.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| telemetry.py | Replaces MAVLink transport with ROS 2 pub/sub for detections and signals; adds ROS node lifecycle helpers. |
| main.py | Initializes and shuts down the ROS 2 telemetry layer during program startup/exit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4