Feature/arcade shop cosmic balls#314
Conversation
|
@TolakaD is attempting to deploy a commit to the Idleon Efficiency Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sludging
left a comment
Sludging
left a comment
There was a problem hiding this comment.
Few minor things to change / experiment with, overall looking good!
| margin={{ right: 'medium' }} | ||
| component={ | ||
| <Box direction="row" align="center" gap="xsmall"> | ||
| <IconImage data={ArcadeData.silverBallImageData()} /> |
There was a problem hiding this comment.
Can probably scale this (and same ones in this row) down a bit .. maybe 0.7? They are a bit big now I think
I leave it up to you if you want to keep it or not, just a thought
There was a problem hiding this comment.
Fixed. You are correct, with 0.7 scale it looks much better.
| const columns = [ | ||
| { | ||
| property: 'upgrade', | ||
| header: 'Upgrade', |
There was a problem hiding this comment.
Is it possible to not have a header? I don't think it really makes sense to have the Upgrade header above the image, it makes it look a bit squashed.
If it's not feasible that's fine just want to see if you can try it out.
There was a problem hiding this comment.
Fixed. Also true, looks better without it.
| const isMaxLevel = bonus.level >= ARCADE_MAX_LEVEL + 1; | ||
| const hasCosmicStepToMax = bonus.level === ARCADE_MAX_LEVEL; |
There was a problem hiding this comment.
Mind adding some comments? for the life of me I can't remember arcade logic and this code seems a bit odd to me so I'd love some clarity on why we check for things like +1
There was a problem hiding this comment.
Added few comments. I will consider moving this logic to arcade.tsx file in the future
2 participants
Uh oh!
There was an error while loading. Please reload this page.