You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-$this->expectExceptionMessage('Couldn\'t connect to host "localhost:66000":');+$this->expectExceptionMessageMatches('/Couldn\'t connect to host "localhost:66000":/');
Apply / Chat
Suggestion importance[1-10]: 2
__
Why: The suggestion to use expectExceptionMessageMatches is functionally equivalent to the existing expectExceptionMessage for this case, as both perform a substring match. The rationale is weak since the current code already correctly handles the OS-dependent part of the exception message by only matching the static prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Tests, Documentation
Description
Reduce TCP socket connection timeout from 1.0 to 0.1 seconds
Fix README code block language identifier from javascript to json
Diagram Walkthrough
File Walkthrough
TcpSocketTest.php
Reduce TCP socket test timeout valuetests/unit/Connection/TcpSocketTest.php
in testThrowsExceptionWhenTryingToConnectToNotExistingServer test
failures
README.md
Fix README code block language syntaxREADME.md
javascripttojsonforcomposer.json example