This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Feature: Slide controller & adjustable RelativeBubbleSlideChild - #11
Open
ming-o-0 wants to merge 13 commits into
Open
Feature: Slide controller & adjustable RelativeBubbleSlideChild#11ming-o-0 wants to merge 13 commits into
ming-o-0 wants to merge 13 commits into
Conversation
Contributor
|
Wouldn't it be better to have the state inside slideActionConroller and instead of using stream parameters only calling slideActionController.goToIndex() or slideActionController.next()? One good example of this behavior is the PageViewController. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
There are 2 arguments added to Showcase widget.
slideNumberStreamTrigger this to go to targeted slide. It is invoked by Stream. If receiving input is over length of slides or less, the showcase is finished. While providing position number less than -1, the showcase will stand still.slideActionStreamTrigger this to control slide to go next, back to previous or close. You can use StreamController to control slide like this example:There is a argument added to Showcase widget
enabledClickOnOverlayToNextSlideWhether to enable click on overlay to go to next slide. (default totrue)extraWidthRightAdditional width to the right. Working only with direction up & down.extraWidthLeftAdditional width to the left. Working only with direction up & down.extraHeightTopAdditional height to the top. Working only with direction left & right.extraHeightBottomAdditional height to the bottom. Working only with direction left & right.Notes
On both slideNumberStream and slideActionStream, I'm trying to cancel subscription when widget is disposed but after assign stream.listen() to a variable, the subscription does not work.