Skip to content

Performance fix - compile pattern only once and reuse #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
and1x0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Performance fix - compile pattern only once and reuse #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion friendly-id/src/main/java/com/devskiller/friendly_id/Base62.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class Base62 {

private static final BigInteger BASE = BigInteger.valueOf(62);
private static final String DIGITS = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
private static final Pattern DIGITS_PATTERN = Pattern.compile("[" + DIGITS + "]*");

/**
* Encodes a number using Base62 encoding.
Expand Down Expand Up @@ -63,7 +64,7 @@ static BigInteger decode(final String string, int bitLimit) {
return throwIllegalArgumentException("String '%s' must not be empty", string);
}

if (!Pattern.matches("[" + DIGITS + "]*", string)) {
if (!DIGITS_PATTERN.matcher(string).matches()) {
throwIllegalArgumentException("String '%s' contains illegal characters, only '%s' are allowed", string, DIGITS);
}

Expand Down