fix(api): handle first-use status and skill search - #61
Open
370025263 wants to merge 1 commit into
Open
Conversation
Return an empty skill-search result before creating an embedding client when the skill index has not been built yet. Allow /api/v1/status to report an uninitialized skill directory with git_branch=null instead of returning 500. Signed-off-by: 370025263 <2385455860@qq.com>
Collaborator
Author
|
不知道干啥的可以解释下吗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix first-use behavior when the skill repository or skill index has not been initialized yet.
Changes
.skill_index.pklis missing./api/v1/statusreturn200withgit_branch: nullfor a non-git skill directory instead of raising a 500.Test plan
make testpassesmake test:932 passed,1 failed.tests/test_e2e_xskill_serve_auto.py::test_canary_flip_promote_and_install_new_versiontimed out waiting for canary promotion.python3.11 -m pytest tests/test_first_use_status_search.py tests/test_server_no_llm_fallback.py tests/test_server_chat_removed.py tests/test_team_create_app.py -q->13 passed.make e2epasses (if the change touches ingestion / install / daemon)Linked issues
Addresses #46