Repository navigation
Keep server-side mods in client-hosted (LAN) packs - #570
Closed
McCal-Codes wants to merge 1 commit into
Closed
McCal-Codes wants to merge 1 commit into
McCal-Codes wants to merge 1 commit into
Conversation
When a player opens their world to LAN, the pack is generated from their own game dir, and auto-exclude-server-side-mods drops mods like Dungeons Arise. The host still loads them though, so Forge kicks every joiner with "mismatched mod list". Skip the auto-exclude when the host is a client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
as i mentioned in the comment under your issue, this is wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #567
First PR ever so let me know if I should change anything!
When a player hosts to LAN, the pack gets generated from their own game folder and
auto-exclude-server-side-modsdrops mods like Dungeons Arise. But the host still loads those, so Forge kicks every joiner with "mismatched mod list".This just skips the auto-exclude when AutoModpack is running on a client (so: a LAN / client-hosted pack), and logs one line saying why. Dedicated servers work exactly like before.
What changed:
ModpackExecutor.buildCandidate, 1 file, ~8 lines.How I tested:
./gradlew formatApply/formatCheckand:loader-universal:shadowJar🤖 Generated with Claude Code