feat: add search component with modal and results handling#35
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive search functionality to the documentation site using Pagefind, a static search library. It introduces a modal-based search UI with keyboard shortcuts, replaces the disabled search input in the header, and integrates Pagefind into the build process.
Changes:
- Added a new Search.astro component with modal UI, keyboard shortcuts (Cmd/Ctrl+K), and live search results
- Updated Header.astro to use the new Search component instead of a disabled input field
- Modified build scripts in both root and template package.json to run pagefind after building
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| template/src/components/Search.astro | New search modal component with Pagefind integration |
| template/src/components/Header.astro | Replaced disabled search input with Search component |
| template/package.json | Added pagefind dev dependency and updated build script |
| package.json | Added pagefind dev dependency and updated build script |
| template/pnpm-lock.yaml | Added Pagefind and platform-specific binaries |
| pnpm-lock.yaml | Added Pagefind and platform-specific binaries |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds search functionality to the documentation site using Pagefind. It updates the build process to generate a search index, integrates a new search modal component in the site header, and manages all necessary dependencies for Pagefind.
Search functionality integration:
Search.astrocomponent implementing a modal search UI, keyboard shortcuts (Cmd/Ctrl+K), and live search results using Pagefind.Header.astrowith the new interactiveSearchcomponent. [1] [2]Build process and dependencies:
buildscript in both root and templatepackage.jsonfiles to runpagefindafter building the site, ensuring the search index is generated. [1] [2]pagefindas a development dependency in both root and templatepackage.jsonfiles, and updatedpnpm-lock.yamlaccordingly to include all required Pagefind binaries and dependencies. [1] [2] [3] [4] [5] [6] [7]