chore: remove shikiConfig from markdown settings and update table styles for better integration with prose#30
Merged
Merged
Conversation
…les for better integration with prose
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This pull request attempts to refine styling for custom Table and Tabs components by isolating them from default prose table styles, removes light/dark mode dual theme support from Tabs, updates Table border colors, and removes the explicit shikiConfig from markdown settings.
Changes:
- Modified global CSS to exclude custom Table components from prose table styles using
:not()selectors - Removed light mode styling from Tabs component, hardcoding dark mode appearance
- Updated Table component border colors for improved visual clarity
- Removed shikiConfig syntax highlighting configuration from both astro.config.mjs files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| template/src/styles/global.css | Attempts to exclude custom tables from prose styles, but uses malformed CSS selectors |
| template/src/components/Tabs.astro | Removes light mode support, breaking theme toggle functionality |
| template/src/components/Table.astro | Updates border and background colors for better visual clarity |
| template/astro.config.mjs | Removes explicit syntax highlighting theme configuration |
| astro.config.mjs | Removes explicit syntax highlighting theme configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…oved design consistency
…dability in installation guide
…for improved readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates the visual styling and behavior of the custom
TableandTabscomponents, and refines global CSS to better isolate custom components from default prose styles. It also removes theshikiConfigmarkdown configuration from two config files.Component styling and behavior updates:
Table.astrocomponent's border and background colors for both light and dark modes, and adjusted the table header row and divider styling for improved visual clarity. [1] [2]Tabs.astrocomponent's active/inactive tab colors, background, and panel styles for a more consistent and modern appearance, and updated the corresponding JavaScript classes for tab activation. [1] [2] [3]Global CSS improvements:
global.cssto exclude custom tables (identified by.text-sm), ensuring custom and Markdown tables have distinct appearances in both light and dark modes. [1] [2]Configuration cleanup:
shikiConfig(syntax highlighting theme and options) from bothastro.config.mjsandtemplate/astro.config.mjsto simplify markdown configuration. [1] [2]