Skip to content

Prepare 4.3.5 candidate with changes since public 4.3.4 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MortenFriisSiteImprove merged 1 commit into from
Sep 16, 2026
Merged

Prepare 4.3.5 candidate with changes since public 4.3.4 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
workflow_dispatch:
inputs:
version:
description: 'Package version matching the project at this ref (for example 4.3.4)'
description: 'Package version matching the project at this ref (for example 4.3.5)'
required: true
type: string
permissions:
Expand Down
3 changes: 2 additions & 1 deletion Optimizely_release_change_log.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ Date / Plugin Version / Changes made since last version
2025-09-03 / 4.3.1 / Update icons for Siteimprove rebranding
2026-02-09 / 4.3.2 / Removed toolbar button in favor of integrated button in side panel, fixed bug where publishing while logged out would always open the login popup, and fixed intermittent error when registering highlighting and prepublish callbacks
2026-02-24 / 4.3.3 / Small change on siteimprove.js file
2026-07-14 / 4.3.4 / Resolve preview iframe document at check time, fixing intermittent missing "Run content check" button and content checks running against a blank/stale page
2026-07-14 / 4.3.4 / Resolve preview iframe document at check time, fixing intermittent missing "Run content check" button and content checks running against a blank/stale page
Pending / 4.3.5 / Prevent page-type errors when opening blocks, preserve connection settings and URL mappings, keep CMS startup responsive when the overlay is unavailable, and avoid duplicate automatic rechecks
2 changes: 1 addition & 1 deletion SiteImprove.Optimizely.Plugin/SiteImprove.Optimizely.Plugin.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PackageProjectUrl>https://github.com/Siteimprove/CMS-plugin-Optimizely</PackageProjectUrl>
<PackageIcon>icon.png</PackageIcon>
<Description>Optimizely plugin from SiteImprove</Description>
<Version>4.3.4</Version>
<Version>4.3.5</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
19 changes: 19 additions & 0 deletions docs/releases/4.3.5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# 4.3.5 release candidate

Changes since the public 4.3.4 package in this repository.

## Fixes and improvements

- **Open blocks without page-type errors.** Opening a standalone block no longer causes the plugin to treat it as a page. Normal operation resumes when you return to a page.
- **Keep your settings when refreshing the connection token.** API credentials, URL mappings, automatic recheck preferences, and your chosen plugin interface are preserved. A failed refresh keeps the existing token.
- **Save URL mappings reliably.** Mappings are retained on the first save, and you can remove all mappings without an error.
- **Keep working when the Siteimprove panel cannot load.** A slow or unavailable panel no longer holds up the CMS editor. Reload the editor to retry loading the panel.
- **Avoid duplicate automatic rechecks.** Plugin reinitialization no longer causes duplicate recheck requests when a page is published.

## Scope and known limitations

This candidate targets Optimizely CMS 12. Standalone block checking remains unsupported. Blocks rendered within a page remain part of that page's checked content. When opening a block separately, the panel can retain the previous page's report.

The current-preview fix for Prepublish and highlighting was already included in the public 4.3.4 package and is not a new change in 4.3.5.

Manual installation and acceptance testing of the candidate on the Windows demo instance are required before publication.
2 changes: 1 addition & 1 deletion docs/testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Status: the package checks and all five real-CMS browser tests passed on x64 Lin

This branch is based on `main` at `b23e48e7b12d8b3170d4595be28b61c16b39eeef`, after PRs #11, #12 and #13 merged. It includes the dependency-lockfile package exclusion from #12. The existing backend tests, browser tests, npm commands and functional workflow remain available. The CMS suite has its own `playwright.cms.config.ts` and `tests/cms` directory. The shared SDK pin also applies to the functional workflow, which installs that exact SDK alongside .NET 6.

The public project keeps its `net6.0` target, version `4.3.4`, and `EPiServer.CMS.UI.Core [12.0.2,13.0.0)` dependency range. The HTTP client factory constructor delegates to the existing request factory from PR #13; its error handling and regression tests are preserved. Release candidates must pass the existing functional workflow as well as the package/CMS workflow.
The public project keeps its `net6.0` target, version `4.3.5`, and `EPiServer.CMS.UI.Core [12.0.2,13.0.0)` dependency range. The HTTP client factory constructor delegates to the existing request factory from PR #13; its error handling and regression tests are preserved. Release candidates must pass the existing functional workflow as well as the package/CMS workflow.

| Component | Pinned baseline |
| --- | --- |
Expand Down
Loading