Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/live-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

The manual **Live Siteimprove smoke test** workflow builds and tests a candidate, installs those exact bytes into a fresh disposable CMS, then opens the real overlay. Live tests run only on the newer CMS profile. It does not replace the overlay, manufacture report data or invoke its command queue from the test.

The first smoke test checks existing API entitlement, authenticates through the direct-login popup, opens the panel and requires an authenticated successful report response for the exact mapped public URL. The selectors and response contract follow the AEM/WordPress test approach; they still need confirmation with the first live account run. A second live scenario scans a persisted synthetic draft with a missing image alternative, saves a correction as a new draft revision, and scans again. Both checks must carry their distinct run markers, enter the running state, and return to the recheck control with the active-check indicator cleared. Live run 35017790911 passed the report and draft-handoff smoke checks. The suite now also requires the documented WCAG 1.1.1 Level A check, SIA-R2 (Image without a text alternative), before the fix and its absence in the visible accessibility results after the fix. These new result assertions still require live validation; they fail instead of skipping when the result cannot be found.
The first smoke test checks existing API entitlement, authenticates through the direct-login popup, opens the panel and requires an authenticated successful report response for the exact mapped public URL. The selectors and response contract follow the AEM/WordPress test approach; they still need confirmation with the first live account run. A second live scenario scans a persisted synthetic draft with a missing image alternative, saves a correction as a new draft revision, and scans again. Both checks must carry their distinct run markers, enter the running state, and return to the recheck control with the active-check indicator cleared. Live run 35017790911 passed the report and draft-handoff smoke checks. The suite now also requires the WCAG 1.1.1 Level A check, SIA-R2 (Image missing a text alternative), before the fix and its absence in the visible accessibility results after the fix. These new result assertions still require live validation; they fail instead of skipping when the result cannot be found.

## Configure before enabling

Expand Down
4 changes: 2 additions & 2 deletions tests/browser/result-navigation.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ const { test, expect } = require('@playwright/test');

async function fixture(page, expanded, issue) {
await page.setContent(`<button aria-expanded="${expanded}" onclick="const open=this.getAttribute('aria-expanded')==='true';this.setAttribute('aria-expanded',!open);document.querySelector('section').hidden=open">Accessibility</button>
<section ${expanded ? '' : 'hidden'}>${issue ? '<p>Image without a text alternative</p>' : '<p>No accessibility issues</p>'}</section>
<section ${expanded ? '' : 'hidden'}>${issue ? '<p>Image missing a text alternative</p>' : '<p>No accessibility issues</p>'}</section>
<button>Recheck draft</button>`);
}

test('opens collapsed accessibility results to expose the documented issue', async ({ page }) => {
test('opens collapsed accessibility results to expose the image alternative issue', async ({ page }) => {
const { openAccessibilityResults, resultViewState } = await import('../live/result-view.mjs');
await fixture(page, false, true);
await openAccessibilityResults(page);
Expand Down
4 changes: 2 additions & 2 deletions tests/live/accessibility-rule.mjs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// Official check name and mapping:
// Rule mapping (the UI label was confirmed separately):
// https://help.siteimprove.com/support/solutions/articles/80000448514
// https://help.siteimprove.com/support/solutions/articles/80000448497
export const imageAlternativeRule = Object.freeze({
id: 'SIA-R2',
apiId: 2,
criterion: '1.1.1',
level: 'A',
label: 'Image without a text alternative',
label: 'Image missing a text alternative',
});
Loading