Match live report identity to the requested page URL - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live run received authenticated, error-free SDK responses with valid issue counts, but the test rejected their URL fields. Match the exact crawled page against the polling request's
urlparameter, as the WordPress live runner does. Require a nonempty responsemainUrlwithout assuming that it is the crawled page address.Keep authentication, success and numeric issue-count checks. Regression cases accept a separate report link and reject the wrong requested page, missing links, unauthenticated responses and invalid issue counts. Safe diagnostics distinguish request URL matching from report-link presence without exposing either URL.
Validation: 17 local unit tests and all CI checks passed. The approved live run passed authenticated report lookup for the exact mapped URL, report-panel opening, and fresh handoff/loading-state exit for both saved draft revisions. The missing-image-alternative result assertion remains explicitly skipped; correct issue detection and removal are not yet established.