chore(agentctl): drop descriptor keys agentctl does not read - #2656
Conversation
agentctl rejects unknown descriptor tables and fields, so the retired `preflight`, `provider`, `identity_check`, `checkpoint_untracked`, `verification_operations` and `[conflicts]` entries go. The files agentctl writes into a worker worktree now live under `.agentctl/` (prompt, result schema, result); .gitignore excludes them and keeps project.toml tracked. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YHwAE9cH8DjXFSorzfSxD8
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 013bfce528
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [workspace] | ||
| provider = "git-worktree" | ||
| root = "/realm/worktrees" | ||
| default_base = "origin/master" |
There was a problem hiding this comment.
After removing provider and verification_operations, xtask/tests/pre_push_agentctl_lease_test.rs::dev_services_cache_identity_excludes_allocated_ports still requires provider == "git-worktree" and calls expect("verification operations") on the deleted array. Any test run containing this integration test now fails deterministically, blocking the repository's local verification gate; update or remove those assertions with the descriptor change.
AGENTS.md reference: AGENTS.md:L212-L214
Useful? React with 👍 / 👎.
1 participant
agentctl (sinnix refactor/agentctl-structure) rejects descriptor tables and fields it does not read, and writes a worker's prompt, schema and result under
.agentctl/instead of.lane/..agentctl/project.toml: removepreflight,preflight_timeout_seconds,provider,identity_check,checkpoint_untracked,verification_operations,[conflicts]..gitignore:.agentctl/*with!.agentctl/project.toml.Behaviour-neutral for current agentctl (the keys were ignored); required once the sinnix branch deploys, which otherwise reports the project out of service.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YHwAE9cH8DjXFSorzfSxD8