Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agentctl/project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ result = "exit"
cache = "tree+environment"

[operations.verify_quick]
description = "Check the Nix flake format without starting development services"
exec = ["nix", "fmt", "--", "--check", "flake.nix"]
description = "Run database-free compile, lint, format, pattern, and Nix checks"
exec = ["xtask", "check", "--full", "--skip-preflight"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Start dev_services before compiling

When AgentCTL verifies a fresh worktree where dev_services has not already been started, the new --skip-preflight argument bypasses ensure_compile_ready (xtask/src/commands/check.rs:504-510) and proceeds to compilation that expands live SQLx macros. The fresh evidence relative to the earlier review is this newly added hidden flag: it changes the failure path but cannot make compilation database-free, so automatic publication still fails unless the matching service happens to exist; arrange a supported dev_services dependency/start before this operation.

AGENTS.md reference: AGENTS.md:L226-L230

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the behavioral test gate

When this remains the sole workspace verifier via verification_operations = ["verify_quick"], the new --full argument enables formatting, linting, forbidden-pattern, and Nix checks and compiles test targets, but CheckCommand::execute never runs the tests. The fresh evidence is that the replacement command still contains no xtask test operation, so behavioral failures that compile cleanly can pass the only automatic publication gate; include the required broad test operation alongside this check.

AGENTS.md reference: AGENTS.md:L212-L214

Useful? React with 👍 / 👎.

pool = "normal"
result = "exit"
cache = "tree+environment"
Expand Down
4 changes: 2 additions & 2 deletions crate/sinex-primitives/src/events/payloads/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ pub mod media;
pub mod messaging;
pub mod metrics;
pub mod music;
pub mod process;
pub mod prediction;
pub mod process;
pub mod semantic;
pub mod shell;
pub mod social;
Expand Down Expand Up @@ -82,8 +82,8 @@ pub use media::*;
pub use messaging::*;
pub use metrics::*;
pub use music::*;
pub use process::*;
pub use prediction::*;
pub use process::*;
pub use semantic::*;
pub use shell::*;
pub use social::*;
Expand Down
2 changes: 1 addition & 1 deletion crate/sinex-primitives/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ pub mod output_kind;
pub mod pacing;
pub mod parser;
pub mod polylogue_protocol;
pub mod primitives;
pub mod prediction_domain;
pub mod primitives;
pub mod privacy;
pub mod public_ref;
pub mod query;
Expand Down
4 changes: 2 additions & 2 deletions crate/sinexctl/src/commands/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ pub mod lifecycle;
pub mod llm;
pub mod metrics;
pub mod ops;
pub mod privacy;
pub mod predictions;
pub mod privacy;
pub mod query;
pub mod query_units;
pub mod record;
Expand Down Expand Up @@ -62,8 +62,8 @@ pub use lifecycle::LifecycleCommands;
pub use llm::LlmCommand;
pub use metrics::MetricsCommands;
pub use ops::OpsCommands;
pub use privacy::PrivacyCommand;
pub use predictions::PredictionsCommand;
pub use privacy::PrivacyCommand;
pub use query::QueryCommand;
pub use query_units::QueryUnitsCommand;
pub use record::RecordCommand;
Expand Down
12 changes: 10 additions & 2 deletions crate/sinexctl/tests/validation_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,16 @@ async fn mcp_catalog_backing_methods_are_typed_read_only_rpc() -> TestResult<()>
fn mcp_wire_tools_declare_read_only_annotations() -> TestResult<()> {
for tool in tools() {
let encoded = serde_json::to_value(&tool)?;
assert_eq!(encoded["annotations"]["readOnlyHint"], true, "{}", tool.name);
assert_eq!(encoded["annotations"]["destructiveHint"], false, "{}", tool.name);
assert_eq!(
encoded["annotations"]["readOnlyHint"], true,
"{}",
tool.name
);
assert_eq!(
encoded["annotations"]["destructiveHint"], false,
"{}",
tool.name
);
}
Ok(())
}
Expand Down
42 changes: 21 additions & 21 deletions crate/sinexd/src/api/rpc_registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -533,27 +533,27 @@ fn build_registry_impl() -> RpcRegistry {
handle_dlq_requeue, handle_documents_get, handle_documents_get_chunks,
handle_documents_get_chunks_redacted, handle_documents_search, handle_events_annotate,
handle_events_cards, handle_events_lineage, handle_events_query,
handle_events_relation_evidence, handle_events_structural_join, handle_health_effect_record,
handle_health_intake_record,
handle_hyprland_workspace_switch, handle_lifecycle_archive, handle_lifecycle_restore,
handle_lifecycle_status, handle_link_entities, handle_llm_budget_report,
handle_llm_embedding_estimate, handle_llm_prompts_list, handle_llm_route_explain,
handle_ops_cancel, handle_ops_get, handle_ops_list, handle_ops_start,
handle_predictions_register, handle_predictions_report, handle_predictions_resolve,
handle_privacy_policy_backend_add, handle_privacy_policy_dictionary_add,
handle_privacy_policy_field_bind, handle_privacy_policy_field_unbind,
handle_privacy_policy_list, handle_privacy_policy_rule_add,
handle_privacy_policy_rule_remove, handle_privacy_policy_rule_set_enabled,
handle_privacy_policy_scope_bind, handle_privacy_policy_seed_builtin,
handle_privacy_shadow_audit, handle_private_mode_disable_service,
handle_private_mode_enable_service, handle_private_mode_status_service,
handle_replay_approve_operation, handle_replay_cancel_operation,
handle_replay_create_operation, handle_replay_execute_operation,
handle_replay_list_operations, handle_replay_operation_status,
handle_replay_preview_operation, handle_replay_submit_operation, handle_retrieve_blob,
handle_runtime_drain, handle_runtime_health, handle_runtime_list,
handle_runtime_list_active, handle_runtime_resume, handle_runtime_set_horizon,
handle_semantic_epoch_create, handle_semantic_epoch_list, handle_semantic_lane_create,
handle_events_relation_evidence, handle_events_structural_join,
handle_health_effect_record, handle_health_intake_record, handle_hyprland_workspace_switch,
handle_lifecycle_archive, handle_lifecycle_restore, handle_lifecycle_status,
handle_link_entities, handle_llm_budget_report, handle_llm_embedding_estimate,
handle_llm_prompts_list, handle_llm_route_explain, handle_ops_cancel, handle_ops_get,
handle_ops_list, handle_ops_start, handle_predictions_register, handle_predictions_report,
handle_predictions_resolve, handle_privacy_policy_backend_add,
handle_privacy_policy_dictionary_add, handle_privacy_policy_field_bind,
handle_privacy_policy_field_unbind, handle_privacy_policy_list,
handle_privacy_policy_rule_add, handle_privacy_policy_rule_remove,
handle_privacy_policy_rule_set_enabled, handle_privacy_policy_scope_bind,
handle_privacy_policy_seed_builtin, handle_privacy_shadow_audit,
handle_private_mode_disable_service, handle_private_mode_enable_service,
handle_private_mode_status_service, handle_replay_approve_operation,
handle_replay_cancel_operation, handle_replay_create_operation,
handle_replay_execute_operation, handle_replay_list_operations,
handle_replay_operation_status, handle_replay_preview_operation,
handle_replay_submit_operation, handle_retrieve_blob, handle_runtime_drain,
handle_runtime_health, handle_runtime_list, handle_runtime_list_active,
handle_runtime_resume, handle_runtime_set_horizon, handle_semantic_epoch_create,
handle_semantic_epoch_list, handle_semantic_lane_create,
handle_semantic_lane_diff_record_entity_relation, handle_semantic_lane_diffs_list,
handle_semantic_lane_discard, handle_semantic_lane_outputs_list,
handle_semantic_lane_outputs_seed_canonical_graph,
Expand Down
6 changes: 5 additions & 1 deletion crate/sinexd/src/automata/document_parser_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,11 @@ async fn document_parser_terminal_outputs_stamp_equivalence_key_and_semantics_ve
.equivalence_key
.as_deref()
.expect("document.parsed equivalence_key must be set");
let document_id = parsed.payload.get("document_id").and_then(|value| value.as_str()).expect("document_id");
let document_id = parsed
.payload
.get("document_id")
.and_then(|value| value.as_str())
.expect("document_id");
assert_eq!(
parsed_key,
sinex_primitives::derivation::derived_equivalence_key(
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading