-
Notifications
You must be signed in to change notification settings - Fork 2
chore: delete the manual rebuild engine and the generic repair product #4698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f81bdd5
chore: delete the manual rebuild engine and the daemon bulk-rebuild r…
Sinity 01041be
chore: delete the generic repair product; raw convergence keeps one o…
Sinity bdb4458
chore: retire the storage/index FTS shim and rewrite maintenance docs…
Sinity 93570e8
chore: delete the declared-not-routed candidate-build operation contract
Sinity 5a6eed0
wip: checkpoint of interrupted lane repair-engine-delete
Sinity 7b19c4b
test: retarget surviving proofs at their new owners
Sinity a1ac09e
Merge remote-tracking branch 'origin/master' into lane/repair-engine-…
Sinity 0bd70ef
chore: close the retired surfaces after the master merge
Sinity e1f820f
test: drop the proofs the deleted engines owned
Sinity bde2e4e
Merge remote-tracking branch 'origin/master' into lane/repair-engine-…
Sinity 84adc4e
test: resolve the maintenance Literal and drop the retired failure count
Sinity 253f99c
Merge remote-tracking branch 'origin/master' into lane/repair-engine-…
Sinity d603062
Merge remote-tracking branch 'origin/master' into lane/repair-engine-…
Sinity acf07df
Merge remote-tracking branch 'origin/master' into lane/repair-engine-…
Sinity f09887f
test: point the daemon proofs at converge_materialization
Sinity b645eaf
test: resolve a real config behind the daemon config seam
Sinity 1a33b6b
docs: name the surviving materialization entry point
Sinity 5ddcbed
Merge remote-tracking branch 'origin/master' into lane/repair-engine-…
Sinity c576801
Merge remote-tracking branch 'origin/master' into lane/repair-engine-…
Sinity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
tests/unit/devtools/test_verification_scenario.py::test_list_scenarios_reports_live_paths_without_baseline_countsruns, it still evaluatesnext(...)for an entry namedrebuild-safetyand asserts that scenario's old payload. Removing it from_SCENARIO_NAMESandlist_scenarios()therefore raisesStopIteration, so the managed suite fails; remove or replace that expectation with a retained scenario.Useful? React with 👍 / 👎.