chore(agentctl): drop descriptor keys agentctl does not read - #4689
chore(agentctl): drop descriptor keys agentctl does not read#4689Sinity wants to merge 1 commit into
Conversation
agentctl rejects unknown descriptor tables and fields, so the retired `preflight`, `provider`, `identity_check`, `checkpoint_untracked`, `verification_operations`, `[conflicts]` and `[owner_adapters]` entries go. The files agentctl writes into a worker worktree now live under `.agentctl/` (prompt, result schema, result); .gitignore excludes them and keeps project.toml tracked. tests/unit/devtools/test_verify.py stops asserting the removed key; nothing else in the repository reads it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YHwAE9cH8DjXFSorzfSxD8
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Folded into #4681, which carries the descriptor cleanup on top of the pytest-slot change. |
- `.agentctl/project.toml` drops `[conflicts]`, `[owner_adapters]` and the environment preflight; agentctl on the host refuses unknown tables and fields, and nothing in this repository reads them. - `.gitignore` keeps `.agentctl/project.toml` tracked and ignores what agentctl writes beside it. - Tests: the descriptor contract asserts the `verify` and `publish` workspace keys; the receipt test derives its future mtime from the file, not the host clock; the pytest_slot verb helper keeps the job id. Folds #4689. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YHwAE9cH8DjXFSorzfSxD8
1 participant
agentctl (sinnix refactor/agentctl-structure) rejects descriptor tables and fields it does not read, and writes a worker's prompt, schema and result under
.agentctl/instead of.lane/..agentctl/project.toml: removepreflight,preflight_timeout_seconds,provider,identity_check,checkpoint_untracked,verification_operations,[conflicts]and[owner_adapters]..gitignore:.agentctl/*with!.agentctl/project.toml.tests/unit/devtools/test_verify.py: drop the assertion onverification_operations; no devtools code reads it.Behaviour-neutral for current agentctl (the keys were ignored); required once the sinnix branch deploys, which otherwise reports the project out of service.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YHwAE9cH8DjXFSorzfSxD8