-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: unify assertion and run status vocabularies #3657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,14 @@ | ||
| """``OperationStatus``: the scheduling status enum shared by every Operation ack. | ||
| """Compatibility import for the canonical ``OperationStatus`` enum. | ||
|
|
||
| Split out of :mod:`polylogue.operations.operation_contract` (polylogue-8s70): | ||
| that module's other export, ``OperationFollowUp``, subclasses | ||
| ``polylogue.surfaces.payloads.SurfacePayloadModel`` (a pydantic base), which | ||
| pulls in a wide swath of the archive/semantic pricing and payload machinery | ||
| (observed ~280ms of import cost). ``OperationStatus`` is a plain ``str, Enum`` | ||
| with zero runtime dependency on any of that -- but importing it from the same | ||
| module used to force the whole chain onto callers who only want the status | ||
| enum, notably :mod:`polylogue.readiness.capability`, which is on the hot path | ||
| of every ``polylogue status``/``polylogue agents status`` invocation. | ||
| The canonical enum lives in :mod:`polylogue.core.enums` so storage DDL and | ||
| operation surfaces share one vocabulary without a dependency cycle. This | ||
| module remains the stable import path for callers that only need the status | ||
| type. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from enum import Enum | ||
|
|
||
|
|
||
| class OperationStatus(str, Enum): | ||
| """Scheduling status carried by every Operation ack. | ||
|
|
||
| Terminal vs in-flight semantics are intentionally simple: | ||
|
|
||
| * ``ACCEPTED`` — the operation passed validation and was admitted into | ||
| the registry. A follow-up hint is populated so clients can poll for | ||
| completion. | ||
| * ``REJECTED`` — the request failed validation, lacked permissions, | ||
| collided with an existing idempotency key, or otherwise could not be | ||
| admitted. ``error`` is populated; ``follow_up`` is omitted. | ||
| * ``PENDING`` — admitted but not yet started. Distinguishes the brief | ||
| window where an ack has been issued before the worker picks up the | ||
| work; useful for queued operations. | ||
| * ``RUNNING`` / ``COMPLETED`` / ``FAILED`` are re-emitted by status | ||
| surfaces after the work has begun or finished (see | ||
| :mod:`polylogue.readiness.capability`). The initial scheduling | ||
| response is always one of ``ACCEPTED``, ``REJECTED``, or ``PENDING``. | ||
| """ | ||
|
|
||
| ACCEPTED = "accepted" | ||
| REJECTED = "rejected" | ||
| PENDING = "pending" | ||
| RUNNING = "running" | ||
| COMPLETED = "completed" | ||
| FAILED = "failed" | ||
|
|
||
| from polylogue.core.enums import OperationStatus | ||
|
|
||
| __all__ = ["OperationStatus"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.