Fix SKU allocation validation bypass - #1
Closed
Sinck wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents
allow_allocation_on_validation_failurefrom allowing a machine without an assigned SKU to skip SKU assignment. The two policies now retain distinct semantics: explicitly ignoring unassigned machines is separate from allowing validation failures for an assigned SKU.Related issues
None.
Type of Change
Breaking Changes
Testing
Additional Notes
Review the policy split:
ignore_unassigned_machinesapplies only when no SKU is assigned, whileallow_allocation_on_validation_failureapplies only after validation of an assigned SKU fails.