Fix arbitrary mk_test_ API key bypass in production - #99
Conversation
Validate that API keys starting with `mk_test_` are only treated as automatically valid in non-production environments (e.g. development). In production, keys with the `mk_test_` prefix must be explicitly configured in the `MANDAT_API_KEYS` environment variable. Added unit tests to verify this behavior. Co-authored-by: Simonc44 <216070312+Simonc44@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
Addresses a security vulnerability where arbitrary API keys starting with
mk_test_were accepted unconditionally on the Vercel production deployment. Now, arbitrarymk_test_keys are only bypassed whenNODE_ENVis not"production". In production, they must be explicitly listed in theMANDAT_API_KEYSlist to be valid.PR created automatically by Jules for task 4057962513949404288 started by @Simonc44