Skip to content

🛡️ Sentinel: [HIGH] Fix overly permissive CORS in /api/visits #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Simonc44 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [HIGH] Fix overly permissive CORS in /api/visits #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,9 @@
**Vulnerability:** Running `pnpm install` in the agent environment caused an unintended downgrade of `lucide-react` in `pnpm-lock.yaml`.
**Learning:** The agent's global or cached `pnpm` version/config might conflict with the project's lockfile, especially when specific versions are pinned in `package.json`.
**Prevention:** Always verify lockfile changes after installation and use `git checkout` to restore unrelated changes if they occur.

## 2026-07-06 - [Overly Permissive CORS on Internal API]

**Vulnerability:** The `/api/visits` endpoint was configured with `Access-Control-Allow-Origin: "*"`, exposing visitor data and counter increment logic to any cross-origin request.
**Learning:** Internal APIs used exclusively by the application's own frontend should not have CORS enabled, as relative fetches already operate on the same origin.
**Prevention:** Default to no CORS for internal endpoints and only enable it with a strict whitelist if external access is explicitly required.
Loading