Repository navigation
Community themes: tap a screenshot to see it large, zoom in, and install from there - #319
Merged
Merged
Conversation
…ap, to look at before installing: pinch or double-tap to zoom in where the fingers are and drag around it, with [ GitHub ] for its repo and [ install ] (or [ use ] once installed) under it; a tap on the card's name still installs or applies it, and Back returns to the grid where it was Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thank you so much, this is a lovely addition! Picking a theme from those small thumbnails was guesswork. Now you can actually look at the terminal colors and the wallpaper before installing. The pinch zoom feels right, and keeping the grid's scroll position on Back is a nice touch. Thanks for the tests for the zoom math too. I'll build on it in a few follow-up commits: the French strings (values-fr landed after you opened this) and a color scheme row on the preview page. Thanks again! |
SimonSchubert
added a commit
that referenced
this pull request
Nov 19, 2026
…which lint failed on since #319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In community themes you pick a theme from a small thumbnail, which is too small to see its terminal colors or its wallpaper. Now a tap on a theme's screenshot opens it large inside the panel, so you can look before you install:
[ GitHub ]opens the theme's repo, and[ install ]asks the same "install …?" as before. Once the theme is installed the button is[ use ], and the theme in use shows✓ in use.‹or Back returns to the grid at the same scroll position.A tap on a card's name or status still installs or applies the theme, as before. The full-screen image viewer that Files and the widget store use is unchanged.
The zoom is a small
ZoomableImageinui/. Its edge clamp and zoom-around-a-point math are plain functions with a JVM test (ImageZoomTest). The preview decodes the screenshot at screen size, and the cards keep their 400 px samples../gradlew :owl:test :app:testFossDebugUnitTest :owl:owlJar :app:assembleFossDebug :app:lintFossDebugpasses, and:app:lintPlayDebugtoo‹return to the grid where it was, and[ install ]and a tap on the card's name both open the install confirmationstrings_store.xmlwith everyvalues-*translation (store_theme_use,store_theme_github)#277 (Catalan) adds
values-ca. If it lands first, these two strings need Catalan too. I'll add them.🤖 Generated with Claude Code