Skip to content

Bridge chooses axes, rounds, and preparation from one review-kind table #44

Closed

Description

@Simon-AI-coding

Parent

#43

What to build

The Bridge chooses a review's axes, the rounds each axis earns, and the preparation that fills its briefs from one review-kind table, with exactly one kind in it: code. Nothing a caller can observe changes — --axis both still runs Standards then Spec, the Spec axis still earns its one re-review, a bad axis name is still refused, every receipt and Next Call is byte-for-byte what it was — but the five places that today each hard-code Code Review on their own (scope resolution and preparation in the main flow, the expansion of both, rounds per lineage, the accepted axis names, and the per-axis brief dispatch) now each ask the table. Document Review (#43) is the second row of that table; this ticket makes adding a row a local change rather than five edits.

The table is a contract the next tickets couple to: a row names its axes in run order, the rounds per axis, and the preparation that builds a brief per axis and a receipt. ReviewPreparation becomes the code row's preparation and is not otherwise edited; the per-axis dispatch it carries today moves so that a preparation owns only its own axes.

The Bridge stays one file (#43: the single-file symlink install and the by-path test harness are the reasons).

Acceptance criteria

  • One table holds, per review kind, its axes in run order, the rounds each axis earns, and the preparation that fills its briefs; code is its only row and every one of the five hard-coded sites reads from it
  • The main flow resolves a Review Scope and prepares through the table's row, not by naming Code Review's preparation itself
  • rounds_per_lineage, the both expansion, and the accepted --axis values are the table's answers, and a kind with no such axis is refused before any Lane opens with the same wording as today
  • Every existing Bridge test passes unchanged — no assertion edited, no expected brief, receipt, or Next Call altered — and both shell suites stay green
  • The Glossary's terms are used for the new names (review kind, Code Review, Axis Brief), and no ADR is contradicted

Blocked by

  • None — can start immediately.

Routing

Workflow: refactor
Executor: codex
Model: gpt-5.6-sol
Effort: xhigh
Review: codex gpt-5.6-sol xhigh
Reasons: Existing code changes shape with behaviour frozen → refactor; #2–#4 couple to the table's shape → core; it crosses the argument layer, rounds, and the main flow → complex; executor and review set by the user at confirmation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions