Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
4 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #399
Why
Limusic could only play through the local computer's audio devices. Users with a Chromecast or Google Cast speaker on their network had no way to cast from the desktop app.
What changed
Discovery and Cast session (
crates/cast)_googlecast._tcp.localdevices.CC1AD845), heartbeats, play/pause/seek/volume, and a synchronous STOP on disconnect and on app exit, so the receiver does not keep playing from its buffer.LAN audio proxy and playback sync (
src-tauri)mpvstays the muted master clock. After the receiver starts, mpv is aligned back to the receiver once, and drift correction runs afterwards. This reduces the ~3 s startup lag to about 1 s.UI and docs
DevicePicker.docs/CHROMECAST.md: troubleshooting (network, VPN, Windows Firewall) and limitations. README feature line and THIRD-PARTY-NOTICES updated.Changes to existing behaviour
AppState::user_seekinstead ofplayer.seek, so they are also mirrored to the receiver. As a side effect they are published to device link / Listen Together like a slider seek.AppState::set_output_volume.audioproxy.rs: the audio route is now a shared function used by the loopback and LAN listeners; loopback behaviour is unchanged.Dependencies and CI
mdns-sd,rust_cast(pullsprotobuf*into Cargo.lock)..github/windows-exe-imports.txt: addediphlpapi.dll(network interface lookup used by mDNS).playback-effects.check.mjs: the mock now provides the cast store functions.Known limitations
Testing
Manual, Windows + a physical Chromecast (3rd gen): discovery, casting, play/pause, seek, volume, automatic track change, startup alignment and drift correction, title/artist/cover on the TV, clean stop of the TV and of the LAN proxy when quitting from the tray.
Not tested on hardware: Linux, macOS, speaker groups.
Automated:
cargo test -p limusic-app --lib(331 passed),pnpm test,pnpm check(0 errors), CI green.AI assistance
Partially assisted by Claude.