don't replace collision polies with empty arrays on noclip - #54
Open
Bottinator22 wants to merge 2 commits into
Open
Bottinator22 wants to merge 2 commits into
Bottinator22 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing this messes up a lot of things as entity queries now find you if your bounding box (which is quite large) is within the query range. This results in noclipping players triggering pressure plates and automatic doors when just in the general area of them.
Instead, replace it with just a point. Collision is already disabled (by collisionEnabled = false), and a point poly is still not visible (assuming that was the intent of an empty poly) but doesn't cause you to be an entity query magnet.
(this may have caused me immense pain in the past)