Skip to content

Don't add item files if they aren't actually items #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SilverSokolova wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't add item files if they aren't actually items #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/sip_postload.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ for _, value in pairs(files) do
if valid then
if itemData["hasObjectItem"] ~= false then
local itemName = itemData.objectName or itemData.itemName or (itemData.id and itemData.id.."-codex")
if not addedItems[itemName] then
if itemName and not addedItems[itemName] then
addedItems[itemName] = true

local rarity = (itemData.rarity or "common"):lower()
Expand Down Expand Up @@ -93,4 +93,4 @@ end)
local path = "/interface/sip/unsortedItemCategory.patch"
assets.add(path, assets.json("/interface/sip/sip.config:unsortedItemCategory"))
assets.patch("/interface/sip/categories.config", path)
assets.add("/sipDynamicItemDump.json", result)
assets.add("/sipDynamicItemDump.json", result)