Skip to content

fix(web): lock setup wizard fields while a step saves - #4870

Merged
Quick104 merged 2 commits into
mainfrom
fix/setup-wizard-lock-fields-while-saving
Nov 21, 2026
Merged

Quick104 merged 2 commits into
mainfrom
fix/setup-wizard-lock-fields-while-saving

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: Apple N/A (no setup wizard); Android N/A (no setup wizard); Roku N/A (no setup wizard)

In the setup wizard, a step's fields stayed editable while its Continue save was in flight. The save sends the values as they were when Continue was pressed, then marks the step done. So anything the admin typed, toggled, or selected during the save was left out, and the wizard moved to the next step without saying so. Found in review of #4816.

Approach

StepFrame already disables Continue and Skip while a step is busy. It now also wraps the step body in a disabled fieldset, the pattern the admin pages and the Storage step's restart lock already use. Two details:

  • A disabled fieldset doesn't stop a Radix select from opening on pointerdown, so the body also stops pointer input while busy. That covers the Playback and Features selects, which pass no busy flag of their own.
  • Disabling the fields drops focus from the field Enter was pressed in. When the save fails and the step stays open, focus returns to that field.

I considered making useStepSubmit stay on the step when edits arrive mid-save. It would need a new edit counter in the shared useSettingsForm, and the admin would get no visible reason why Continue didn't advance. Locking the inputs prevents the edit in the first place.

The Storage step's own restart fieldset is now partly redundant. It's left alone because #4816 is changing that file.

Validation

  • New StepFrame tests (fields locked and pointer input blocked while busy; focus restored after a failed save) fail on main and pass here. The setup-wizard suite passes.
  • Changed-file ESLint and Prettier, and the app typecheck, pass. CI runs the full web build and test suite.
  • Live check in Chromium at desktop and phone widths: a dev-only route rendered the real StepFrame and settings rows with a slow save. On main, a name edit, a toggle, and a select change made during the save all showed on screen and were missing from the saved batch. With the fix, none of them took. A separate run checked that focus returns to the field after a failed save submitted with Enter. A dev-builder sandbox wasn't available during this run, and a set-up sandbox can't reach the wizard anyway, so the check wasn't run on a full server.

Evidence: https://evidence.siloserver.org/r/silo-server/setup-wizard-lock-fields-while-saving/

Risks

While a step saves, its fields look disabled for the length of the save. A step that renders a control which must stay usable during a save would need to move it outside the step body. None does today: the Storage step's restart messages are status text, and they stay readable to screen readers because the body is disabled, not inert.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Ran as a follow-up run: one member per round.

Plan check: Opus (claude-opus-5-5, medium). It replaced inert with pointer-events blocking, so the Storage step's restart status and alert stay announced, and it simplified focus tracking to record the element at submit.

Background review: 1 round, last reviewed dbbe25a

Member Round 1
Sol (gpt-6.2-sol, high) 8/10

Answered: S1 (a pending embedding provider Add that finishes during the Features save) predates this PR and is tracked in #4883.

Visual review: 1 round, captures from dbbe25a

Member Round 1
Sol (gpt-6.2-sol, high) better, 8/10

Answered: a 24 px shift on completion comes from the harness's result line, not the wizard. Faint disabled chevron and switch thumb come from the shared disabled styling, which this change doesn't touch.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; Codex (review)
  • Model(s): claude-opus-5-5 (implementation, plan check); gpt-6.2-sol (visual and background review); claude-sonnet-5-5 (code-review finders)
  • Involvement: Fully AI-generated; not yet human verified
  • Adversarial review: code-review at medium. Its findings that a Radix select still opens and that focus is lost after Enter were both fixed. The plan check and visual review are in Council review above.

🤖 Generated with Claude Code

Quick104 and others added 2 commits November 20, 2026 22:44
An edit typed after Continue and before the save returned missed the saved
batch, and the step then advanced past it. StepFrame now disables the step's
fields while it is busy, the same way it already disabled Continue and Skip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A disabled fieldset doesn't stop a Radix select from opening on pointerdown,
so the step body also drops pointer input while busy. Locking the fields
drops focus from the one Enter was pressed in; when the save fails and the
step stays open, focus returns to it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/M 50–199 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8d2fa01b-1d98-4e35-b3bf-e62d3356db56
Commits

Reviewing files that changed from the base of the PR and between 5a3156b and dbbe25a.

Files selected for processing: 2

  • web/src/pages/setup-wizard/StepFrame.test.tsx
  • web/src/pages/setup-wizard/StepFrame.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T04:31:09.714066Z dbbe25a PR opened
🔒 Security Review ✅ Completed 2026-11-21T04:33:10.175243Z dbbe25a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gpt-6.2-sol, reviewed dbbe25a)

@Quick104
Quick104 merged commit d364630 into main Nov 21, 2026
23 checks passed
@Quick104
Quick104 deleted the fix/setup-wizard-lock-fields-while-saving branch November 21, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/M 50–199 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant