Repository navigation
fix(web): lock setup wizard fields while a step saves - #4870
Conversation
An edit typed after Continue and before the save returned missed the saved batch, and the step then advanced past it. StepFrame now disables the step's fields while it is busy, the same way it already disabled Continue and Skip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A disabled fieldset doesn't stop a Radix select from opening on pointerdown, so the step body also drops pointer input while busy. Locking the fields drops focus from the one Enter was pressed in; when the save fails and the step stays open, focus returns to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 2 minutes. View limit details
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Problem
Related issue: N/A
Validation tasks: none
Other clients: Apple N/A (no setup wizard); Android N/A (no setup wizard); Roku N/A (no setup wizard)
In the setup wizard, a step's fields stayed editable while its Continue save was in flight. The save sends the values as they were when Continue was pressed, then marks the step done. So anything the admin typed, toggled, or selected during the save was left out, and the wizard moved to the next step without saying so. Found in review of #4816.
Approach
StepFramealready disables Continue and Skip while a step is busy. It now also wraps the step body in a disabled fieldset, the pattern the admin pages and the Storage step's restart lock already use. Two details:I considered making
useStepSubmitstay on the step when edits arrive mid-save. It would need a new edit counter in the shareduseSettingsForm, and the admin would get no visible reason why Continue didn't advance. Locking the inputs prevents the edit in the first place.The Storage step's own restart fieldset is now partly redundant. It's left alone because #4816 is changing that file.
Validation
StepFrametests (fields locked and pointer input blocked while busy; focus restored after a failed save) fail onmainand pass here. The setup-wizard suite passes.StepFrameand settings rows with a slow save. Onmain, a name edit, a toggle, and a select change made during the save all showed on screen and were missing from the saved batch. With the fix, none of them took. A separate run checked that focus returns to the field after a failed save submitted with Enter. A dev-builder sandbox wasn't available during this run, and a set-up sandbox can't reach the wizard anyway, so the check wasn't run on a full server.Evidence: https://evidence.siloserver.org/r/silo-server/setup-wizard-lock-fields-while-saving/
Risks
While a step saves, its fields look disabled for the length of the save. A step that renders a control which must stay usable during a save would need to move it outside the step body. None does today: the Storage step's restart messages are status text, and they stay readable to screen readers because the body is disabled, not inert.
Checklist
Council review
Ran as a follow-up run: one member per round.
Plan check: Opus (claude-opus-5-5, medium). It replaced
inertwith pointer-events blocking, so the Storage step's restart status and alert stay announced, and it simplified focus tracking to record the element at submit.Background review: 1 round, last reviewed dbbe25a
Answered: S1 (a pending embedding provider Add that finishes during the Features save) predates this PR and is tracked in #4883.
Visual review: 1 round, captures from dbbe25a
Answered: a 24 px shift on completion comes from the harness's result line, not the wizard. Faint disabled chevron and switch thumb come from the shared disabled styling, which this change doesn't touch.
AI Disclosure
🤖 Generated with Claude Code