Repository navigation
fix(web): keep rating source names readable on every surface - #4827
Conversation
A rating's source name ("IMDb", "RT") was faded to 75% of its row's text
color. On the item detail score row that put it below 4.5:1 for most
accent presets, and in the Watch Together movie panel it read 4.01:1 with
no accent at all. Draw the name in its row's color at full strength, and
keep it secondary to the score with a lighter weight and smaller size.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 1 minute. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
The comment claimed each caller's color reads on its surface, which dark accents on main and bright hero artwork don't yet hold to. Say only that the name reads as well as the score beside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Problem
Related issue: N/A
Validation tasks: none (#1229 C1, the accent on web surfaces, still holds)
Other clients: N/A (web-only styling; each client draws its own rating row)
A rating's source name ("IMDb", "RT", "MC") was drawn at 75% of its row's text color. In two of the three places the web app shows ratings, that put it below WCAG AA 4.5:1:
In the home hero, the name over artwork read at 65% of its score's contrast.
This change draws the name at full strength, so it reads exactly as well as the score beside it everywhere.
Approach
RatingEntryno longer fades the name: it takes its row's text color as is. It stays secondary to the score by size and weight (medium, down from semibold, next to the bold score). Each caller picks its own color for its surface, and the fade pulled the name below that color's contrast.The neutral
text-foreground/75that #4772 used for chip labels doesn't fit here: in the Watch Together chips it would make the name brighter than its muted score.On main, the indigo, violet, and slate presets and a black accent still leave the score row below 4.5:1, because the score itself fails there (indigo 2.92:1). #4780 fixes accent-colored text globally. With both changes, every rating name reads 6.45:1 or more on Cinema Dark.
Validation
ScoreRow, the hero's metadata wrapper, and the Watch Together chip markup, and applied the accent throughaccentDeclarations. It covered every accent preset, a black custom accent, and no accent, each with high contrast off and on, on main and on this branch, with and without fix(web): keep accent-colored text readable on Cinema Dark #4780. No sandbox server was available, so this wasn't checked on a live page.pnpm run lint,format:check,build,budget:check, andmake test-webpass. Lint reports 0 errors, and none of its warnings are in the changed file.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/rating-name-contrast/
Surface and build: web, Cinema Dark, desktop width, base f0c80d2 and 318e8f1 (40a01f7 changes only a code comment). The hero is measured over a solid stand-in for its scrim, since real artwork varies. Phone and tablet widths weren't captured: the change only alters color and weight, and the lighter weight makes the name narrower.
Risks
None identified. The TMDB entry is a logo image and doesn't change.
Checklist
Council review
Visual review: 1 round, on captures of 318e8f1's change.
All three noted that indigo still fails on main because the score does; that is #4780's part (see Approach). Opus and Gemini noted that the name and score now differ only by size and weight. They agreed the name still reads as secondary, so it stays. Two findings predate this change and were left alone: the name sits on the row's vertical center rather than the score's baseline, and the TMDB logo chip is lighter in high contrast.
Background review: round 1 on 318e8f1.
Sol's S1 (the code comment claimed each caller's color reads on its surface, which dark accents on main and bright detail-hero artwork don't yet meet) is fixed in 40a01f7, a comment-only change. Sol also measured the score row over bright detail-hero artwork; the name now matches its score there too, and text over bright backdrops in that column is tracked in #4569. Opus and Gemini found nothing.
AI Disclosure
🤖 Generated with Claude Code