Skip to content

fix(web): keep rating source names readable on every surface - #4827

Merged
Quick104 merged 2 commits into
mainfrom
fix/rating-name-contrast
Nov 21, 2026
Merged

Quick104 merged 2 commits into
mainfrom
fix/rating-name-contrast

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none (#1229 C1, the accent on web surfaces, still holds)

Other clients: N/A (web-only styling; each client draws its own rating row)

A rating's source name ("IMDb", "RT", "MC") was drawn at 75% of its row's text color. In two of the three places the web app shows ratings, that put it below WCAG AA 4.5:1:

  • Item detail score row (accent-colored text in the detail header, measured on the page background): with an admin accent set, the name read 1.11–4.21:1 for seven of the eight accent presets and a black accent. With fix(web): keep accent-colored text readable on Cinema Dark #4780's lightened accent text, indigo, red, and black still read 4.15–4.43:1.
  • Watch Together movie panel (muted gray chips): the name read 4.01:1 with no accent at all, and 4.27:1 in high contrast.

In the home hero, the name over artwork read at 65% of its score's contrast.

This change draws the name at full strength, so it reads exactly as well as the score beside it everywhere.

Approach

RatingEntry no longer fades the name: it takes its row's text color as is. It stays secondary to the score by size and weight (medium, down from semibold, next to the bold score). Each caller picks its own color for its surface, and the fade pulled the name below that color's contrast.

The neutral text-foreground/75 that #4772 used for chip labels doesn't fit here: in the Watch Together chips it would make the name brighter than its muted score.

On main, the indigo, violet, and slate presets and a black accent still leave the score row below 4.5:1, because the score itself fails there (indigo 2.92:1). #4780 fixes accent-colored text globally. With both changes, every rating name reads 6.45:1 or more on Cinema Dark.

Validation

  • Contrast measured in Chromium from computed styles on a temporary dev-only harness route, which isn't committed. It rendered the real ScoreRow, the hero's metadata wrapper, and the Watch Together chip markup, and applied the accent through accentDeclarations. It covered every accent preset, a black custom accent, and no accent, each with high contrast off and on, on main and on this branch, with and without fix(web): keep accent-colored text readable on Cinema Dark #4780. No sandbox server was available, so this wasn't checked on a live page.
  • pnpm run lint, format:check, build, budget:check, and make test-web pass. Lint reports 0 errors, and none of its warnings are in the changed file.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/rating-name-contrast/

Surface and build: web, Cinema Dark, desktop width, base f0c80d2 and 318e8f1 (40a01f7 changes only a code comment). The hero is measured over a solid stand-in for its scrim, since real artwork varies. Phone and tablet widths weren't captured: the change only alters color and weight, and the lighter weight makes the name narrower.

Risks

None identified. The TMDB entry is a logo image and doesn't change.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Visual review: 1 round, on captures of 318e8f1's change.

Member Round 1
Sol (gpt-6.2-sol, xhigh) better, 8/10
Opus (claude-opus-5-5, high) better, 8/10
Gemini (gemini-4-neon, xhigh) better, 8/10

All three noted that indigo still fails on main because the score does; that is #4780's part (see Approach). Opus and Gemini noted that the name and score now differ only by size and weight. They agreed the name still reads as secondary, so it stays. Two findings predate this change and were left alone: the name sits on the row's vertical center rather than the score's baseline, and the TMDB logo chip is lighter in high contrast.

Background review: round 1 on 318e8f1.

Member Round 1 (318e8f1)
Sol (gpt-6.2-sol, xhigh) 8/10
Opus (claude-opus-5-5, high) 9/10
Gemini (gemini-4-neon, xhigh) 9/10

Sol's S1 (the code comment claimed each caller's color reads on its surface, which dark accents on main and bright detail-hero artwork don't yet meet) is fixed in 40a01f7, a comment-only change. Sol also measured the score row over bright detail-hero artwork; the name now matches its score there too, and text over bright backdrops in that column is tracked in #4569. Opus and Gemini found nothing.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; T3 Code delegated tasks for the visual and background reviews (Codex, Claude, and Antigravity providers); headless Chromium (Playwright) for measurements and captures
  • Model(s): claude-opus-5-5 (implementation, review); gpt-6.2-sol, claude-opus-5-5, gemini-4-neon (council)
  • Involvement: Fully AI-generated; the agent verified it in a dev-only harness, a person hasn't yet
  • Adversarial review: a single-pass code review found no defects. The plan round was skipped because the fix is a two-class change whose cause is visible in the source. See Council review above.

🤖 Generated with Claude Code

A rating's source name ("IMDb", "RT") was faded to 75% of its row's text
color. On the item detail score row that put it below 4.5:1 for most
accent presets, and in the Watch Together movie panel it read 4.01:1 with
no accent at all. Draw the name in its row's color at full strength, and
keep it secondary to the score with a lighter weight and smaller size.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:34:03.286819Z 318e8f1 PR opened
🔒 Security Review ✅ Completed 2026-11-21T03:40:19.307813Z 40a01f7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9c1e94e7-9b1c-42d5-839e-bd3fa99b5a4c
Commits

Reviewing files that changed from the base of the PR and between 41e1749 and 40a01f7.

Files selected for processing: 1

  • web/src/components/ratings/RatingEntry.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
The comment claimed each caller's color reads on its surface, which
dark accents on main and bright hero artwork don't yet hold to. Say
only that the name reads as well as the score beside it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@Quick104
Quick104 merged commit c1e36dc into main Nov 21, 2026
18 checks passed
@Quick104
Quick104 deleted the fix/rating-name-contrast branch November 21, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant