Repository navigation
fix(web): keep chip labels at the boosted color in high contrast - #4802
Conversation
The playback route badges and the downloads worker badge draw their label in the foreground color at 75%. High contrast lightens the surfaces behind them (a hovered Activity row, the dashboard panel), so the translucent label lost contrast there: 4.83:1 on a hovered row with a white accent, against 6.07:1 in normal mode. In high contrast the label now takes the boosted muted color, like other secondary text: 5.68:1 on that row and 7.67:1 on the panel. Normal mode is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 30 minutes. View limit details
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (Claude Opus 5.5, reviewed 7b7b8cb)
One nit, about where the high-contrast decision lives. I found no correctness problems. The arbitrary variant compiles to html[data-high-contrast=true] .<class> (specificity 0-1-2), so it beats text-foreground/75 (0-1-0) in the utilities layer. Tailwind picks the class up from the LABEL_CLASS constant, and the built CSS contains the rule.
Problem
Related issue: N/A
Validation tasks: none
Other clients: Apple N/A (these admin chips are in the web app); Android N/A (same); Roku N/A (same)
In high contrast mode, the labels on the playback route badges ("Network", "Transcode", "Proxy") and the downloads worker badge read worse than in normal mode on some surfaces. #4772 drew them in the foreground color at 75%. High contrast lightens the surfaces behind them, and the 25% the label lets through picks that up: on a hovered Activity row the label drops from 6.07:1 to 4.83:1 with a white custom accent, and from 6.19:1 to 4.98:1 with no accent. It still passes AA, but high contrast is meant to make text easier to read, not harder.
In high contrast mode the label now takes the boosted muted color, like the app's other secondary text. Normal mode is unchanged.
Approach
The label color is now a
--chip-labeltheme token, defined next to the--<status>-labeltokens these badges already use: 75% foreground in normal mode (unchanged from #4772, which keeps the label readable on light accent tints) and the boosted muted color in the high contrast block. Both badges usetext-chip-label.On hovered rows the label still sits slightly under its normal-mode contrast (5.86:1 against 6.19:1 with no accent), because high contrast lightens the hover surface itself. Other secondary text on that surface behaves the same way.
Validation
PlaybackRouteBadgesandWorkerBadgefor no accent, the eight presets, and a white custom accent, on the card, a hovered Activity row, the dashboard panel, and a selected Preparation row. Contrast comes from the browser's computed colors and background stack through the WCAG formula.Evidence
High-contrast close-ups before and after on a hovered row, the dashboard panel, the card, and a selected row, with the measured contrast tables for both modes.
Evidence: https://evidence.siloserver.org/r/silo-server/accent-chip-labels-high-contrast/
Risks
None identified. The change only applies when high contrast is on.
Follow-up from review of #4772 (adversarial review G1).
Checklist
Council review
Background review: round 1 on 7b7b8cb. Sol and Gemini found nothing. Opus's O1 (use a theme token like the
--<status>-labelones instead of an inline variant) is adopted in a42af2a.Visual review: 1 round, captures from 7b7b8cb
All three found every changed label improved (lowest 4.83:1 to 5.68:1) and nothing else changed. Answered, not changed: in high contrast the label is now close to the value's brightness with no accent, and brighter than accent or status values. High contrast keeps
--primaryat #e8e8ec, so a label bright enough to hold normal-mode contrast on hovered rows (90% white) already outshines it; the weight difference carries the hierarchy there. The accent and status values that fall under 4.5:1 in high contrast predate this change and are covered by the accent-text work (#4780) and #4769.AI Disclosure
🤖 Generated with Claude Code