Skip to content

fix(web): keep chip labels at the boosted color in high contrast - #4802

Merged
Quick104 merged 1 commit into
mainfrom
fix/accent-chip-labels-high-contrast
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/accent-chip-labels-high-contrast

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none
Other clients: Apple N/A (these admin chips are in the web app); Android N/A (same); Roku N/A (same)

In high contrast mode, the labels on the playback route badges ("Network", "Transcode", "Proxy") and the downloads worker badge read worse than in normal mode on some surfaces. #4772 drew them in the foreground color at 75%. High contrast lightens the surfaces behind them, and the 25% the label lets through picks that up: on a hovered Activity row the label drops from 6.07:1 to 4.83:1 with a white custom accent, and from 6.19:1 to 4.98:1 with no accent. It still passes AA, but high contrast is meant to make text easier to read, not harder.

In high contrast mode the label now takes the boosted muted color, like the app's other secondary text. Normal mode is unchanged.

Approach

The label color is now a --chip-label theme token, defined next to the --<status>-label tokens these badges already use: 75% foreground in normal mode (unchanged from #4772, which keeps the label readable on light accent tints) and the boosted muted color in the high contrast block. Both badges use text-chip-label.

On hovered rows the label still sits slightly under its normal-mode contrast (5.86:1 against 6.19:1 with no accent), because high contrast lightens the hover surface itself. Other secondary text on that surface behaves the same way.

Validation

  • Not on a server. Measured with the same temporary dev-only harness as fix(web): keep dimmed chip labels readable on accent tints #4772 (not committed), which renders the real PlaybackRouteBadges and WorkerBadge for no accent, the eight presets, and a white custom accent, on the card, a hovered Activity row, the dashboard panel, and a selected Preparation row. Contrast comes from the browser's computed colors and background stack through the WCAG formula.
  • High contrast: the lowest label goes from 4.83:1 to 5.68:1; on the dashboard panel the "Network" label goes from 6.40:1 to 7.91:1 (no accent).
  • Normal mode: identical before and after (lowest label 5.78:1). Moving the color into the token (a42af2a) left both modes' tables byte-identical.
  • Gate: web lint, format check, typecheck, build, bundle budget, the web test suite, and the local-path and size-ratchet checks pass. No Go or contract files change.

Evidence

High-contrast close-ups before and after on a hovered row, the dashboard panel, the card, and a selected row, with the measured contrast tables for both modes.

Evidence: https://evidence.siloserver.org/r/silo-server/accent-chip-labels-high-contrast/

Risks

None identified. The change only applies when high contrast is on.

Follow-up from review of #4772 (adversarial review G1).

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Background review: round 1 on 7b7b8cb. Sol and Gemini found nothing. Opus's O1 (use a theme token like the --<status>-label ones instead of an inline variant) is adopted in a42af2a.

Member Round 1
Sol (gpt-6.2-sol, xhigh) 9/10
Opus (claude-opus-5-5, high) 8/10
Gemini (gemini-4-neon, xhigh) 9.5/10

Visual review: 1 round, captures from 7b7b8cb

Member Round 1
Sol better, 8/10
Opus better, 7/10
Gemini better, 6/10

All three found every changed label improved (lowest 4.83:1 to 5.68:1) and nothing else changed. Answered, not changed: in high contrast the label is now close to the value's brightness with no accent, and brighter than accent or status values. High contrast keeps --primary at #e8e8ec, so a label bright enough to hold normal-mode contrast on hovered rows (90% white) already outshines it; the weight difference carries the hierarchy there. The accent and status values that fall under 4.5:1 in high contrast predate this change and are covered by the accent-text work (#4780) and #4769.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; T3 Code delegated tasks for the visual and background reviews (Codex, Claude, and Antigravity providers); headless Chromium (Playwright) for captures
  • Model(s): claude-opus-5-5 (implementation); gpt-6.2-sol, claude-opus-5-5, gemini-4-neon (council)
  • Involvement: Fully AI-generated; the agent verified it in a dev-only harness, a person hasn't yet
  • Adversarial review: this change answers Gemini's G1 from fix(web): keep dimmed chip labels readable on accent tints #4772's background review. The plan round was skipped because the fix is a one-class change on three spans. A simplify pass pulled the repeated class into one constant. See Council review above.

🤖 Generated with Claude Code

The playback route badges and the downloads worker badge draw their
label in the foreground color at 75%. High contrast lightens the
surfaces behind them (a hovered Activity row, the dashboard panel), so
the translucent label lost contrast there: 4.83:1 on a hovered row with
a white accent, against 6.07:1 in normal mode. In high contrast the
label now takes the boosted muted color, like other secondary text:
5.68:1 on that row and 7.67:1 on the panel. Normal mode is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 68437deb-26e7-4cdc-a797-2e494dfbaaef
Commits

Reviewing files that changed from the base of the PR and between d979665 and 7b7b8cb.

Files selected for processing: 2

  • web/src/components/PlaybackRouteBadges.tsx
  • web/src/pages/admin-downloads/PreparationTab.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:00:23.447740Z 7b7b8cb PR opened
🔒 Security Review ✅ Completed 2026-11-21T03:02:15.174804Z 7b7b8cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (Claude Opus 5.5, reviewed 7b7b8cb)

One nit, about where the high-contrast decision lives. I found no correctness problems. The arbitrary variant compiles to html[data-high-contrast=true] .<class> (specificity 0-1-2), so it beats text-foreground/75 (0-1-0) in the utilities layer. Tailwind picks the class up from the LABEL_CLASS constant, and the built CSS contains the rule.

@Quick104
Quick104 merged commit 8dd07a8 into main Nov 21, 2026
21 checks passed
@Quick104
Quick104 deleted the fix/accent-chip-labels-high-contrast branch November 21, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant